-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of tripleo services #438
Cleanup of tripleo services #438
Conversation
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/881f7f38d9864d218fa84effc61bab62 ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 25m 31s |
recheck |
recheck
|
14cfa24
to
66c1868
Compare
66c1868
to
117d7f3
Compare
apiVersion: dataplane.openstack.org/v1beta1 | ||
kind: OpenStackDataPlaneService | ||
metadata: | ||
name: tripleo-cleanup | ||
spec: | ||
playbook: osp.edpm.tripleo_cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should have it in the dataplane-operator repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have priory art defining adoption specific service on the fly in the data-plane-adoption repo. The pre-adoption-validation service is defined in the same way.
There is still a retry of tripleo-cleanup playbook in the CI job https://logserver.rdoproject.org/38/438/117d7f34837e55ceefefbf6514fa08c2445fc1a9/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/1f3ca9b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/
the the second try of the playbook succeeds: |
It's two services There may be way to get rid of the |
recheck |
117d7f3
to
3a6938c
Compare
Creates dataplane service 'tripleo-cleanup' which stops, disables and finally removes unit files of tripleo systemd services. The step is executed as last during dataplane adoption. Signed-off-by: Jiri Podivin <[email protected]>
3a6938c
to
752d2c9
Compare
This change depends on a change that failed to merge. Change openstack-k8s-operators/edpm-ansible#649 is needed. |
recheck |
Creates dataplane service 'tripleo-cleanup' which stops, disables
and finally removes unit files of tripleo systemd services.
The step is executed as last during dataplane adoption.
Depends-On: openstack-k8s-operators/edpm-ansible#649