Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of tripleo services #438

Merged

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented May 6, 2024

Creates dataplane service 'tripleo-cleanup' which stops, disables
and finally removes unit files of tripleo systemd services.

The step is executed as last during dataplane adoption.

Depends-On: openstack-k8s-operators/edpm-ansible#649

@jpodivin
Copy link
Contributor Author

jpodivin commented May 6, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/881f7f38d9864d218fa84effc61bab62

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 25m 31s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 18m 00s

@jpodivin
Copy link
Contributor Author

jpodivin commented May 6, 2024

recheck

@gibizer
Copy link
Contributor

gibizer commented May 14, 2024

recheck

  • there is newer versions of the dependency to check
  • in the last CI run there was a failed job execution trial and only the second run of the playbook passed.
�[0;31mfailed: [standalone] (item=tripleo_neutron_l3_agent.service) => {�[0m
�[0;31m    "ansible_loop_var": "item",�[0m
�[0;31m    "changed": false,�[0m
�[0;31m    "invocation": {�[0m
�[0;31m        "module_args": {�[0m
�[0;31m            "daemon_reexec": false,�[0m
�[0;31m            "daemon_reload": false,�[0m
�[0;31m            "enabled": false,�[0m
�[0;31m            "force": null,�[0m
�[0;31m            "masked": true,�[0m
�[0;31m            "name": "tripleo_neutron_l3_agent.service",�[0m
�[0;31m            "no_block": false,�[0m
�[0;31m            "scope": "system",�[0m
�[0;31m            "state": "stopped"�[0m
�[0;31m        }�[0m
�[0;31m    },�[0m
�[0;31m    "item": "tripleo_neutron_l3_agent.service",�[0m
�[0;31m    "msg": "Could not find the requested service tripleo_neutron_l3_agent.service: host"�[0m

@jpodivin jpodivin force-pushed the testing-tripleo-cleanup branch from 14cfa24 to 66c1868 Compare May 15, 2024 08:52
@jpodivin jpodivin changed the title DNM: Testing fcleanup of tripleo services Cleanup of tripleo services May 15, 2024
@jpodivin jpodivin force-pushed the testing-tripleo-cleanup branch from 66c1868 to 117d7f3 Compare May 15, 2024 08:53
@jpodivin jpodivin requested review from fao89, marios and jistr May 15, 2024 08:54
Comment on lines +572 to +577
apiVersion: dataplane.openstack.org/v1beta1
kind: OpenStackDataPlaneService
metadata:
name: tripleo-cleanup
spec:
playbook: osp.edpm.tripleo_cleanup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have it in the dataplane-operator repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have priory art defining adoption specific service on the fly in the data-plane-adoption repo. The pre-adoption-validation service is defined in the same way.

@gibizer
Copy link
Contributor

gibizer commented May 15, 2024

There is still a retry of tripleo-cleanup playbook in the CI job https://logserver.rdoproject.org/38/438/117d7f34837e55ceefefbf6514fa08c2445fc1a9/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/1f3ca9b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/

the first fails with:
https://logserver.rdoproject.org/38/438/117d7f34837e55ceefefbf6514fa08c2445fc1a9/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/1f3ca9b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tripleo-cleanup-tripleo-cleanup-openstack-527h6/logs/openstackansibleee.log

�[0;31mfailed: [standalone] (item=tripleo_neutron_l3_agent.service) => {�[0m
�[0;31m    "ansible_loop_var": "item",�[0m
�[0;31m    "changed": false,�[0m
�[0;31m    "invocation": {�[0m
�[0;31m        "module_args": {�[0m
�[0;31m            "daemon_reexec": false,�[0m
�[0;31m            "daemon_reload": false,�[0m
�[0;31m            "enabled": false,�[0m
�[0;31m            "force": null,�[0m
�[0;31m            "masked": true,�[0m
�[0;31m            "name": "tripleo_neutron_l3_agent.service",�[0m
�[0;31m            "no_block": false,�[0m
�[0;31m            "scope": "system",�[0m
�[0;31m            "state": "stopped"�[0m
�[0;31m        }�[0m
�[0;31m    },�[0m
�[0;31m    "item": "tripleo_neutron_l3_agent.service",�[0m
�[0;31m    "msg": "Could not find the requested service tripleo_neutron_l3_agent.service: host"�[0m
�[0;31m}�[0m

the the second try of the playbook succeeds:
https://logserver.rdoproject.org/38/438/117d7f34837e55ceefefbf6514fa08c2445fc1a9/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/1f3ca9b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tripleo-cleanup-tripleo-cleanup-openstack-6nzph/logs/openstackansibleee.log

@jpodivin
Copy link
Contributor Author

jpodivin commented May 15, 2024

It's two services tripleo_neutron_ovs_agent and tripleo_neutron_l3_agent that are apparently not available when ansible tries to manage them. It is odd, because we are getting list of existing services by service_facts module. This should be fine, since it uses systemctl under the hood.

There may be way to get rid of the not-found status, if we reload everything before executing the primary task.

@jpodivin
Copy link
Contributor Author

recheck

@jpodivin jpodivin force-pushed the testing-tripleo-cleanup branch from 117d7f3 to 3a6938c Compare May 15, 2024 14:42
Creates dataplane service 'tripleo-cleanup' which stops, disables
and finally removes unit files of tripleo systemd services.

The step is executed as last during dataplane adoption.

Signed-off-by: Jiri Podivin <[email protected]>
@jpodivin jpodivin force-pushed the testing-tripleo-cleanup branch from 3a6938c to 752d2c9 Compare May 16, 2024 08:29
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/edpm-ansible#649 is needed.

@jpodivin
Copy link
Contributor Author

recheck

@fao89 fao89 added the check-before-merge/depends-on Don't forget to check depends-on before merging label May 20, 2024
@fao89 fao89 removed the check-before-merge/depends-on Don't forget to check depends-on before merging label May 23, 2024
@fao89 fao89 merged commit f0361e9 into openstack-k8s-operators:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants