Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Ceph docs edit -- the problem was elsewhere #367

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

jistr
Copy link
Contributor

@jistr jistr commented Mar 18, 2024

PR #363 made the Ceph docs slightly inconsistent and didn't seem to fix the docs issue we saw in #338 -- the problem is likely in that PR, here:

#338 (comment)

Let's revert #363 to make Ceph docs consistent again. I created a separate commit to fix the quoting issue in one of the snippets, i think we want to keep that.

jistr added 2 commits March 18, 2024 11:15
This is a part of reverted e41ca20
that i think we want to keep.
@jistr jistr requested review from bogdando, fmount and klgill March 18, 2024 10:21
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6eb6ab4b9bf84c5b834d09c03d86696c

adoption-docs-preview FAILURE in 1m 48s

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmount
Copy link
Contributor

fmount commented Mar 18, 2024

ack and thanks for confirming that syntax was correct.

@jistr
Copy link
Contributor Author

jistr commented Mar 18, 2024

recheck error fetching from rubygems.org

@jistr jistr merged commit d3951b1 into openstack-k8s-operators:main Mar 18, 2024
3 checks passed
@klgill
Copy link
Contributor

klgill commented Mar 18, 2024

@jistr Just so I understand the issue correctly, are you saying that we need the syntax to be "[source,bash]" or else the build breaks?

@jistr
Copy link
Contributor Author

jistr commented Mar 18, 2024

@klgill No, the issue was unrelated, it was missing end of the code block ---- in PR 338. Regarding [source,bash] i only put the state back into how it was before. I saw at least one other Ceph module has [source,bash], so it seemed random to remove it from that one doc, and i put it back to the original state before #363 was merged. #363 was merged only because we thought the CI was broken, otherwise we'd be looking at that patch more carefully i think.

So in conclusion, nothing of importance happened here i think 😁 . PR 363 landed and here we immediately reverted it after we discovered it wasn't the fix we were looking for.

@jistr
Copy link
Contributor Author

jistr commented Mar 18, 2024

We kept just this bit from PR 363 -- cbcf2db

@jistr jistr deleted the b-revert-docs-fix branch April 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants