-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Ceph docs edit -- the problem was elsewhere #367
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6eb6ab4b9bf84c5b834d09c03d86696c ❌ adoption-docs-preview FAILURE in 1m 48s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ack and thanks for confirming that syntax was correct. |
recheck error fetching from rubygems.org |
@jistr Just so I understand the issue correctly, are you saying that we need the syntax to be "[source,bash]" or else the build breaks? |
@klgill No, the issue was unrelated, it was missing end of the code block So in conclusion, nothing of importance happened here i think 😁 . PR 363 landed and here we immediately reverted it after we discovered it wasn't the fix we were looking for. |
We kept just this bit from PR 363 -- cbcf2db |
PR #363 made the Ceph docs slightly inconsistent and didn't seem to fix the docs issue we saw in #338 -- the problem is likely in that PR, here:
#338 (comment)
Let's revert #363 to make Ceph docs consistent again. I created a separate commit to fix the quoting issue in one of the snippets, i think we want to keep that.