Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Glance with Swift backend #288

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Adopt Glance with Swift backend #288

merged 3 commits into from
Mar 25, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Feb 15, 2024 •
edited
Loading

This patch describes the required steps to adopt the OpenStack Image Service
(Glance) with a Swift backend. In TripleO, if a Glance backend is not specified,
Swift is used as the default option. For this reason the test suite is also improved
to make sure we can cover this use case when ENABLED_CEPH_BACKEND is set to False.

Implements: OSPRH-784
Depends-On: #291
Depends-On: #312
Depends-On: #338
Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/51896
Depends-On: openstack-k8s-operators/ci-framework#1212
Depends-On: openstack-k8s-operators/install_yamls#759

@fmount fmount force-pushed the swift_backend branch 2 times, most recently from 1902359 to 3eac98e Compare February 15, 2024 10:07
@fmount fmount marked this pull request as draft February 15, 2024 10:10
@fmount fmount changed the title Swift backend Adopt Glance with a Swift backend Feb 15, 2024
@fmount fmount changed the title Adopt Glance with a Swift backend Adopt Glance with Swift backend Feb 15, 2024
@fmount fmount requested a review from jistr February 15, 2024 10:11
@fmount fmount requested a review from konan-abhi February 15, 2024 10:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/06542203ea9f441e85f0708d303cbb00

❌ data-plane-adoption-osp-17-to-extracted-crc NODE_FAILURE Node request 100-0006921526 failed in 0s
✔️ adoption-docs-preview SUCCESS in 1m 47s

@fmount fmount force-pushed the swift_backend branch 2 times, most recently from 2c05629 to 6c2700e Compare February 19, 2024 10:59
@fmount fmount force-pushed the swift_backend branch 3 times, most recently from 54d973b to 14717a7 Compare February 19, 2024 11:34
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e6fa2ee4dd5e48ebb71b7cd81f605838

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 05m 34s
✔️ adoption-docs-preview SUCCESS in 1m 33s

@fmount fmount force-pushed the swift_backend branch 2 times, most recently from adc2127 to 2048957 Compare February 23, 2024 09:40
@fmount fmount marked this pull request as ready for review February 23, 2024 09:40
@fmount fmount force-pushed the swift_backend branch 2 times, most recently from 6874bfd to 1c27685 Compare February 23, 2024 10:02
@fmount
Copy link
Contributor Author

fmount commented Feb 23, 2024 •
edited
Loading

@cescgina do you know how to trigger a data-plane-adoption job where we don't have Ceph (EDPM_COMPUTE_CEPH_ENABLED=false: I realized in this case Swift is enabled by default) and at the same time trigger the swift adoption and pass glance_backend: swift?

@fmount fmount requested a review from cescgina February 26, 2024 09:13
@fmount fmount force-pushed the swift_backend branch 2 times, most recently from 7855aa8 to 915e0db Compare February 26, 2024 12:39
@fmount fmount mentioned this pull request Feb 26, 2024
Merged
@fmount fmount force-pushed the swift_backend branch 2 times, most recently from 84062cf to 7b566e4 Compare February 26, 2024 14:55
fmount
fmount commented Feb 26, 2024
View reviewed changes
tests/roles/glance_adoption/defaults/main.yaml
# glance_backend can be 'local' or 'ceph'
glance_backend: local
# glance_backend can be 'local', 'ceph' or 'swift'
glance_backend: swift
Copy link
Contributor Author

@fmount fmount Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jistr so this should trigger test_minimal to deploy glance w/ a swift backend. While this would be the default behavior, I'm wondering if you think it's better to pass the var to the playbook itself.
What the minimal use case would be? I think our choices depend on the environment we start with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea the adoption has to follow the configuration of the environment we start with. I'm actually not sure what the Glance backend is when we deploy the Standalone without Ceph, but based on the defaults it's probably Swift, unless it's overriden somewhere else:

https://github.com/openstack/tripleo-heat-templates/blob/811bf370be3b9a4bb29b7234a6f6c16b8290146b/deployment/glance/glance-api-container-puppet.yaml#L227

So changing the test-minimal default to Swift backend makes sense to me. We could feed the variable to the playbook too, but i'm not sure if we want to test with local ever, now that we have Swift... So maybe it's ok just to change the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to keep swift as default (which is aligned w/ what TripleO provides). local shouldn't be tested at all, but we can keep that code because w/ a slightly change we can be ready to test the NFS backend.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1f54ea2f96834160a51420217e7962cd

✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 20m 58s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 09m 53s
✔️ adoption-docs-preview SUCCESS in 1m 32s

@fmount
Copy link
Contributor Author

fmount commented Mar 20, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e7af6a5082d84c99ad95b67351fea073

✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 18m 24s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 13m 45s
✔️ adoption-docs-preview SUCCESS in 2m 07s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4c1171cca5a74db198a9f429e871412c

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3h 00m 34s
✔️ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph SUCCESS in 2h 15m 42s
✔️ adoption-docs-preview SUCCESS in 3m 12s

@fmount
Copy link
Contributor Author

fmount commented Mar 21, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3e65a06ede3a4884b23d09e170c167d8

✔️ data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 15m 06s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph RETRY_LIMIT in 2s
✔️ adoption-docs-preview SUCCESS in 1m 30s

@fmount
Copy link
Contributor Author

fmount commented Mar 21, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/57a5b439e7904e8d8d6112d5c9fef404

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3h 11m 13s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph RETRY_LIMIT in 3h 11m 21s
✔️ adoption-docs-preview SUCCESS in 2m 04s

@fmount
Copy link
Contributor Author

fmount commented Mar 22, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bbdba61efc1b469c8f7afbe489f1f10a

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3h 10m 58s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph RETRY_LIMIT in 2h 46m 14s
✔️ adoption-docs-preview SUCCESS in 2m 06s

@cescgina
Copy link
Contributor

recheck

@fmount
Copy link
Contributor Author

fmount commented Mar 22, 2024

recheck

@fmount
Copy link
Contributor Author

fmount commented Mar 22, 2024

@cescgina an interesting number of rechecks to get CI green: is there a particular known issue?

@cescgina
Copy link
Contributor

@cescgina an interesting number of rechecks to get CI green: is there a particular known issue?

yes, sorry, there are a number of problems going on at once. I was using this to test changes, but I moved now to use a testproject to reduce the noise

@fmount
Copy link
Contributor Author

fmount commented Mar 22, 2024

@cescgina an interesting number of rechecks to get CI green: is there a particular known issue?

yes, sorry, there are a number of problems going on at once. I was using this to test changes, but I moved now to use a testproject to reduce the noise

np, looks like all the dependencies merged, I think this change is good to go as long as the CI is green, or do you have concerns except a green CI?

@cescgina
Copy link
Contributor

@cescgina an interesting number of rechecks to get CI green: is there a particular known issue?

yes, sorry, there are a number of problems going on at once. I was using this to test changes, but I moved now to use a testproject to reduce the noise

np, looks like all the dependencies merged, I think this change is good to go as long as the CI is green, or do you have concerns except a green CI?

I agree, I think it's good to go, we even had some green runs earlier this week, hopefully we can get CI back on track soon and this can be merged

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7b50184bd4bb4e44999026809957ef92

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 2h 59m 11s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph RETRY_LIMIT in 3h 11m 28s
✔️ adoption-docs-preview SUCCESS in 1m 49s

fmount and others added 3 commits March 22, 2024 17:52
@fmount
Glance adoption with Swift backend
a05795d 
This patch describes the required steps to adopt the OpenStack Image
Service (Glance) with a Swift backend. It also improves the testsuite
to make sure we can cover such scenario.

Signed-off-by: Francesco Pantano <[email protected]>
@cescgina @fmount
Add job variant to run test-minimal without ceph
c45bf37 
The jobs should run on all changes except those that only touch the
documentation.
@fmount
Fix ansible issue when using golang templating
73db89d 
This patch introduces the usage of files/ instead of hardcoded
spec. This would likely avoid issues when we use golang templates
and we can mantain files with per-backend configuration.

Signed-off-by: Francesco Pantano <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c376b08383ff4d0c9ed7b47113b11e2c

❌ data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 13m 30s
❌ data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph RETRY_LIMIT in 14m 03s
✔️ adoption-docs-preview SUCCESS in 1m 30s

@fmount
Copy link
Contributor Author

fmount commented Mar 23, 2024

recheck

@fmount
Copy link
Contributor Author

fmount commented Mar 24, 2024

@cescgina @jistr finally green CI. All the dependencies are merged, is it ok to approve and land this patch?

@marios marios merged commit 757faba into openstack-k8s-operators:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konan-abhi konan-abhi konan-abhi left review comments

@SeanMooney SeanMooney SeanMooney left review comments

@cschwede cschwede cschwede requested changes

@cescgina cescgina cescgina approved these changes

@jistr jistr jistr approved these changes

@marios marios marios approved these changes

Assignees
No one assigned
Labels
check-before-merge/depends-on Don't forget to check depends-on before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@fmount @cescgina @jistr @danpawlik @cschwede @bogdando @gibizer @marios @SeanMooney @konan-abhi