Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update services routes #172

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Update services routes #172

merged 1 commit into from
Oct 2, 2023

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Oct 2, 2023

@fao89 fao89 requested a review from stuggi October 2, 2023 08:47
stuggi
stuggi reviewed Oct 2, 2023
View reviewed changes
docs/openstack/glance_adoption.md
Comment on lines -91 to -95
externalEndpoints:
- endpoint: internal
ipAddressPool: internalapi
loadBalancerIPs:
- 172.17.0.80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match the old example you may also want to have the override for ceph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please give me an example?
I didn't find what is the proper way to override ceph

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, maybe what I wrote was confusing. I meant you removed the externalEndpoints in this Using Ceph storage backend section. you might want to add the service override for this, like above for the glanceAPIInternal?

        override:
          service:
            metadata:
              annotations:
                metallb.universe.tf/address-pool: internalapi
                metallb.universe.tf/allow-shared-ip: internalapi
                metallb.universe.tf/loadBalancerIPs: 172.17.0.80
            spec:
              type: LoadBalancer

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/469915dd045648b29595e5411bc90a3f

❌ data-plane-adoption-github-rdo-centos-9-crc-single-node RETRY_LIMIT in 15m 38s

@fao89
Copy link
Contributor Author

fao89 commented Oct 2, 2023

recheck

stuggi
stuggi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/89ee86e073b74bdbb855ee70bba0ae98

❌ data-plane-adoption-github-rdo-centos-9-crc-single-node RETRY_LIMIT in 16m 00s

@fao89
Copy link
Contributor Author

fao89 commented Oct 2, 2023

recheck

@fao89 fao89 merged commit 1b31dd1 into openstack-k8s-operators:main Oct 2, 2023
1 check passed
@jistr jistr mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuggi stuggi stuggi approved these changes

@jistr jistr jistr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @jistr @stuggi