Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable horizon adoption test temporarily due to timeout OSPCIX-82 #168

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

marios
Copy link
Contributor

@marios marios commented Sep 26, 2023

This blocks the current-podified promotion [1]

[1] https://issues.redhat.com/browse/OSPCIX-82

@marios marios marked this pull request as draft September 26, 2023 08:34
@@ -40,5 +40,5 @@
(curl --silent --output /dev/stderr --head --write-out "%{http_code}" "$PUBLIC_URL/dashboard/auth/login/?next=/dashboard/") | grep 200
register: horizon_http_status_code
until: horizon_http_status_code is success
retries: 15
retries: 60
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i don't think this will help... i just checked a green run, and it worked on first attempt eg

https://logserver.rdoproject.org/55/155/68fc680ea521ac3f8d573c9437c346682a88334d/github-check/data-plane-adoption-github-rdo-centos-9-crc-single-node/8ae277a/controller/data-plane-adoption-tests-repo/data-plane-adoption/tests/logs/test_minimal_out_2023-09-21T05:28:27EDT.log

TASK [horizon_adoption : check horizon dashboard is reachable] *****************
changed: [localhost] => {"attempts": 1, "changed": true, "cmd": "set -euxo pipefail\n\n\n\nPUBLIC_URL=$(oc get horizon horizon -o jsonpath='{.status.endpoint}')\n(curl --silent --output /dev/stderr --head --write-out \"%{http_code}\" \"$PUBLIC_URL/dashboard/auth/login/?next=/dashboard/\") | grep 200\n", "delta": "0:00:02.567249", "end": "2023-09-21 05:43:57.259737", "msg": "", "rc": 0, "start": "2023-09-21 05:43:54.692488", "stderr": "++ oc get horizon horizon -o 'jsonpath={.status.endpoint}'\n+ PUBLIC_URL=http://horizon-public-openstack.apps-crc.testing\n+ grep 200\n+ curl --silent --output /dev/stderr --head --write-out '%{http_code}' 'http://horizon-public-openstack.apps-crc.testing/dashboard/auth/login/?next=/dashboard/'\nHTTP/1.1 200 OK\r\ndate: Thu, 21 Sep 2023 09:43:54 GMT\r\nserver: Apache\r\ncontent-length: 9622\r\nexpires: Thu, 21 Sep 2023 09:43:57 GMT\r\ncache-control: max-age=0, no-cache, no-store, must-revalidate, private\r\nvary: Cookie,Accept-Language\r\nx-frame-options: DENY\r\ncontent-language: en\r\nset-cookie: csrftoken=po6eksqShA5RlSqfmMEhM44YT2FUXrrQ0uEzXv88dKt8i3JaqWmIrYBimZjZO5Xh; Path=/; SameSite=Lax\r\ncontent-type: text/html; charset=utf-8\r\nset-cookie: e5f5cd6be3649e37cb21c32e2b124b26=98fb01b8c877ec8393e6e1a2bc9dc0d7; path=/; HttpOnly", "stderr_lines": ["++ oc get horizon horizon -o 'jsonpath={.status.endpoint}'", "+ PUBLIC_URL=http://horizon-public-openstack.apps-crc.testing", "+ grep 200", "+ curl --silent --output /dev/stderr --head --write-out '%{http_code}' 'http://horizon-public-openstack.apps-crc.testing/dashboard/auth/login/?next=/dashboard/'", "HTTP/1.1 200 OK", "date: Thu, 21 Sep 2023 09:43:54 GMT", "server: Apache", "content-length: 9622", "expires: Thu, 21 Sep 2023 09:43:57 GMT", "cache-control: max-age=0, no-cache, no-store, must-revalidate, private", "vary: Cookie,Accept-Language", "x-frame-options: DENY", "content-language: en", "set-cookie: csrftoken=po6eksqShA5RlSqfmMEhM44YT2FUXrrQ0uEzXv88dKt8i3JaqWmIrYBimZjZO5Xh; Path=/; SameSite=Lax", "content-type: text/html; charset=utf-8", "set-cookie: e5f5cd6be3649e37cb21c32e2b124b26=98fb01b8c877ec8393e6e1a2bc9dc0d7; path=/; HttpOnly"], "stdout": "200", "stdout_lines": ["200"]}

but in any case i am using this pull request to get a node hold with https://review.rdoproject.org/r/c/testproject/+/50187 to see if there is some connectivity issue?

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bcb4e6e0e52c46c9a77eaf8a8f8ee171

data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 18m 09s

@fao89
Copy link
Contributor

fao89 commented Sep 26, 2023

@ashu-011 do you know if anything changed in horizon-operator?

@ashu-011
Copy link
Contributor

@ashu-011 do you know if anything changed in horizon-operator?

Hi @fao89 , I am not aware of anything which could have caused this , let me check and get back on this . Maybe @bshephar could give us more info if anything has changed with the operator .

@marios marios changed the title WIP try bumping horizon reachable timeout for debug Disable horizon adoption test temporarily due to timeout OSPCIX-82 Sep 26, 2023
@marios marios requested a review from fao89 September 26, 2023 13:09
@marios
Copy link
Contributor Author

marios commented Sep 26, 2023

as discussed in today's call @jistr I am now disabling the horizon test #168 (comment)

@marios marios marked this pull request as ready for review September 26, 2023 13:10
@marios marios requested a review from jistr September 26, 2023 13:11
@marios marios requested a review from cescgina September 26, 2023 13:11
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5e5ed6125b5a41dfbe626d22fee7a464

data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 46m 56s

@arxcruz
Copy link

arxcruz commented Sep 26, 2023

recheck

@fao89
Copy link
Contributor

fao89 commented Sep 26, 2023

we should merge as is, the dataplane is breaking because it needs #166

@arxcruz
Copy link

arxcruz commented Sep 26, 2023

we should merge as is, the dataplane is breaking because it needs #166

If you have the power, do it! :)

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/835ff233baff437c8b55ee6bc2f4865e

data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 48m 59s

@marios
Copy link
Contributor Author

marios commented Sep 27, 2023

This is failing on #166
and that one needs this in order to merge

so I am merging this

@marios marios merged commit 9c1ee16 into openstack-k8s-operators:main Sep 27, 2023
@marios
Copy link
Contributor Author

marios commented Sep 27, 2023

@ashu-011 do you know if anything changed in horizon-operator?

Hi @fao89 , I am not aware of anything which could have caused this , let me check and get back on this . Maybe @bshephar could give us more info if anything has changed with the operator .

I suspect the issue was caused by

openstack-k8s-operators/horizon-operator#212 Update horizon to use service override #212

Seems relevant (routes for reaching the pod/service) and it merged Sep 20th which seems to line up with when this issue was seen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants