Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workload Setup] reuse edpm-deploy-instance.sh script #149

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

karelyatin
Copy link
Contributor

The script creates an instance with all the dependencies, let's reuse the script.

Depends-On: openstack-k8s-operators/install_yamls#530 Closes #132

The script creates an instance with all the dependencies,
let's reuse the script.

Depends-On: openstack-k8s-operators/install_yamls#530
Closes openstack-k8s-operators#132
@karelyatin karelyatin requested a review from jistr September 12, 2023 05:55
@SeanMooney
Copy link
Contributor

That script is inteded to be used with a greenfiled deployment
for adoption all the networks and images should be created by tripleo before the adoption
the install yamlls script should not be used with the tripleo deploy OpenStack so I'm not really sure this is a good idea.

@karelyatin
Copy link
Contributor Author

<< That script is inteded to be used with a greenfiled deployment
<< for adoption all the networks and images should be created by tripleo before the adoption
<< the install yamlls script should not be used with the tripleo deploy OpenStack so I'm not really sure this is a good idea.

@SeanMooney I reused that to avoid duplicated steps being done in workload preparation for adoption(environment prepared as part of "make standalone").
What part of tripleo handles images/network preparation as standalone setup didn't had those pre created? iirc there are some tempest roles that used to create it in TripleO jobs.
Me not sure of all the use cases but i noticed many scripts used for adoption document are from install_yamls.

@jistr
Copy link
Contributor

jistr commented Sep 13, 2023

@SeanMooney So this is indeed being used before adoption, it's a part of the dev env setup. I'd say let's roll with it to keep it DRY, and we can unwrap the script contents back into our docs if we hit problems with using the script directly.

Copy link
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jistr jistr merged commit 87a5a13 into openstack-k8s-operators:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sample workload should have networking attached
4 participants