Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new lib-common VolumeSource structs #454

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Oct 15, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from Akrog and eharney October 15, 2024 20:53
@dprince dprince force-pushed the custom_vol_source branch 2 times, most recently from 5808ca8 to da67d6d Compare October 16, 2024 14:55
@dprince dprince changed the title WIP: Use github.com/dprince/lib-common/modules/storage Use github.com/dprince/lib-common/modules/storage Oct 25, 2024
@dprince dprince changed the title Use github.com/dprince/lib-common/modules/storage Update to new lib-common VolumeSource structs Oct 25, 2024
@fmount fmount mentioned this pull request Oct 31, 2024
1 task
@fmount
Copy link
Contributor

fmount commented Oct 31, 2024

we need to rebase this patch.

@dprince
Copy link
Contributor Author

dprince commented Nov 5, 2024

/retest

@fmount
Copy link
Contributor

fmount commented Nov 5, 2024

/test cinder-operator-build-deploy-kuttl

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 54d6e95 into openstack-k8s-operators:main Nov 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants