Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit][kuttl]Check for multiple TestAsserts #386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented May 10, 2024

Add a new pre-commit check to avoid using more than one TestkAssert in a
single kuttl assert file as that can lead to false positives as only the
last TestAssert is run by kuttl.

Fortunately there was no such issue in this repo.

Add a new pre-commit check to avoid using more than one TestkAssert in a
single kuttl assert file as that can lead to false positives as only the
last TestAssert is run by kuttl.

Fortunately there was no such issue in this repo.
@openshift-ci openshift-ci bot requested review from ASBishop and olliewalsh May 10, 2024 16:05
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gibizer
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gibizer
Copy link
Contributor Author

gibizer commented May 13, 2024

/test precommit-check

go: go.uber.org/[email protected]: Get "https://proxy.golang.org/go.uber.org/goleak/@v/v1.3.0.mod": net/http: TLS handshake timeout

@gibizer
Copy link
Contributor Author

gibizer commented May 13, 2024

/test cinder-operator-build-deploy-tempest

1 similar comment
@abays
Copy link
Contributor

abays commented May 14, 2024

/test cinder-operator-build-deploy-tempest

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@gibizer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cinder-operator-build-deploy-tempest ac64fd2 link false /test cinder-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abays
Copy link
Contributor

abays commented May 14, 2024

@gibizer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/cinder-operator-build-deploy-tempest ac64fd2 link false /test cinder-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Tempest has failed twice in a row with the same error (but doesn't seem related to this change):

': 'volume 3.0', 'X-Auth-Token': '<omitted>'}
        Body: None
    Response - Headers: {'date': 'Tue, 14 May 2024 10:25:27 GMT', 'server': 'Apache', 'content-length': '109', 'openstack-api-version': 'volume 3.0', 'vary': 'OpenStack-API-Version', 'x-compute-request-id': 'req-7b546d81-db0f-4cf4-8265-709b19dd28c1', 'x-openstack-request-id': 'req-7b546d81-db0f-4cf4-8265-709b19dd28c1', 'content-type': 'application/json', 'set-cookie': '33e2d45401feb6ecb7f87041ac073655=6824efc2d241dc5561d6764c78634055; path=/; HttpOnly; Secure; SameSite=None', 'connection': 'close', 'status': '404', 'content-location': 'https://cinder-public-openstack.apps.oko-08.oooci.ccitredhat.com/v3/volumes/0aa30a16-bfcc-4ccf-a5bc-b34ef0d131fe'}
        Body: b'{"itemNotFound": {"code": 404, "message": "Volume 0aa30a16-bfcc-4ccf-a5bc-b34ef0d131fe could not be found."}}'



======
Totals
======
Ran: 204 tests in 287.7399 sec.
 - Passed: 197
 - Skipped: 6
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 1
Sum of execute time for each test: 470.2424 sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants