Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate go.mod indirect dependencies #347

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Feb 19, 2024

During the golang version bump we unintentionally introduced a too new
indirect dependency on kube-openapi:

k8s.io/[email protected]

This is not required by any of our direct deps and this is also a
version that required golang 1.21. If your system has golang 1.21
installed the this dependency might force go mod tidy to change the
golang version in the go.mod file to 1.21.

This patch removed all the indirect dependencies and let go mod tidy to
regenerate them to get rid of the too new kube-openapi version.

@gibizer
Copy link
Contributor Author

gibizer commented Feb 19, 2024

/test functional

  * could not run steps: execution cancelled
  * could not run steps: step functional failed: test "functional" failed: could not watch pod: context canceled 
�[36mINFO�[0m[2024-02-19T15:49:30Z] Reporting job state 'failed' with reason 'executing_graph:interrupted' 

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

During the golang version bump we unintentionally introduced a too new
indirect dependency on kube-openapi:

k8s.io/[email protected]

This is not required by any of our direct deps and this is also a
version that required golang 1.21. If your system has golang 1.21
installed the this dependency might force go mod tidy to change the
golang version in the go.mod file to 1.21.

This patch removed all the indirect dependencies and let go mod tidy to
regenerate them to get rid of the too new kube-openapi version.
@gibizer gibizer force-pushed the regenerate-go-mod-file branch from 2e855b7 to 2208678 Compare February 26, 2024 13:12
@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2024
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@gibizer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cinder-operator-build-deploy-tempest 2208678 link false /test cinder-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fd2c289 into openstack-k8s-operators:main Feb 26, 2024
6 of 7 checks passed
ASBishop pushed a commit to ASBishop/cinder-operator that referenced this pull request Mar 11, 2024
…galera_pvcs_kuttl

Delete galera pvcs in kuttl test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants