Use IP addresses associated with network attachments #272
Conversation
ASBishop
force-pushed
the
storage-network-addrs
branch
2 times, most recently
from
2f62aee to
4660970
Compare
| // but it's safe (and easier) to always configure them regardless of the | ||
| // backend type. The configuration also relies on the fact that the LVM | ||
| // backend must have only one replica. | ||
| if len(networkAttachmentAddrs) > 0 { |
There was a problem hiding this comment.
Would you consider doing this conditionally only when using LVM backends?
The idea would be to change the extendCustomServiceConfig that is being called in L556 to return 2 values, the customServiceConfig and a boolean for usesLVM. We may need to change the method name.
The extendCustomServiceConfig shouldn't need a lot of code changes, basically:
- Not
breakontoken == "enabled_backends" - Create a new variable
hasLVM := falseand anotherfoundDrivers := 0 - Get the
valueas well as thetokenwe are getting onSplitN - Add a new
} else if token == "volume_driver" && value == "cinder.volume.drivers.lvm.LVMVolumeDriver" {where we sethasLVMtotrueand increase thefoundDriverscounter - At the end the actual boolean that determines whether there's LVM or not would be
hasLVM && len(backendNames) ==foundDrivers` because we have to account that it's the default driver and its value could be implicit.
The reason for this is to avoid restarting the container when not using LVM, which are all the production environments.
ASBishop
force-pushed
the
storage-network-addrs
branch
2 times, most recently
from
1552551 to
dcc9ab6
Compare
|
/retest unknown failure deploying openstack-operator |
Configure the cinder-volume service's target_ip_address and target_secondary_ip_addresses using addresses in the network attachment status. This is necessary in order for EDPM compute nodes to be able to make volume attachment requests (via iSCSI or NVMe/TCP) over the storage network. Jira: OSP-28445
ASBishop
force-pushed
the
storage-network-addrs
branch
from
dcc9ab6 to
7cd5920
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, ASBishop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Configure the cinder-volume service's target_ip_address and
target_secondary_ip_addresses using addresses in the network attachment
status. This is necessary in order for EDPM compute nodes to be able to
make volume attachment requests (via iSCSI or NVMe/TCP) over the storage
network.
Jira: OSP-28445