Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config snippet files for better clarity #263

Conversation

ASBishop
Copy link
Contributor

@ASBishop ASBishop commented Sep 7, 2023

Based on feedback from pull request #250, the config snippet files are renamed as follows:

00-config.conf => 00-global-defaults.conf
01-config.conf => 01-service-defaults.conf
02-config.conf => 02-global-custom.conf
03-config.conf => 03-service-custom.conf
04-config.conf => 04-service-custom-secrets.conf

Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Based on feedback from pull request openstack-k8s-operators#250, the config snippet files
are renamed as follows:

00-config.conf => 00-global-defaults.conf
01-config.conf => 01-service-defaults.conf
02-config.conf => 02-global-custom.conf
03-config.conf => 03-service-custom.conf
04-config.conf => 04-service-custom-secrets.conf
@ASBishop ASBishop force-pushed the rename-config-snippets branch from 5a6ef6e to f91d9bf Compare September 8, 2023 18:33
@openshift-ci openshift-ci bot removed the lgtm label Sep 8, 2023
Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, ASBishop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0dc5afa into openstack-k8s-operators:main Sep 11, 2023
1 check passed
@ASBishop ASBishop deleted the rename-config-snippets branch September 11, 2023 20:44
ASBishop pushed a commit to ASBishop/cinder-operator that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants