-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cinderapi to use service override #262
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6fe6fbd
to
7b7b016
Compare
Am I correct that this PR supersedes pull request #248? |
/hold |
7b7b016
to
fb46057
Compare
fb46057
to
4363cf9
Compare
4363cf9
to
97bc3c2
Compare
6af5abe
to
e832fb2
Compare
/test cinder-operator-build-deploy-kuttl |
Removes creation of routes.Those get done in the openstack-operator. Via service overrides the service can be customized. The service operator adds annotation to the service which needs to be exposed as a route. Jira: OSP-26690 Depends-On: openstack-k8s-operators/lib-common#332
e832fb2
to
16d83ab
Compare
/test cinder-operator-build-deploy-kuttl |
The issue we right now is that the we are building the new operator with the current version of the openstack-operator which has not the functionality to create the route for the new service operator version. With this the public endpoint will be a ClusterIP service and is not reachable by the tempest job which is running outside the OCP env. I think we have two options:
|
This would only work if the host tempest is running is using our DNS server where the service endpoint gets registered
|
@stuggi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test cinder-operator-build-deploy-kuttl |
…20056 Connect ovs pod to the tenant network
Removes creation of routes.Those get done in the openstack-operator. Via service overrides the service can be customized. The service operator adds annotation to the service which needs to be exposed as a route.
Jira: OSP-26690
Depends-On: openstack-k8s-operators/lib-common#332