Revamp config process #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using an init container to generate the snippet files that configure each cinder service. Now, the contents are rendered entirely by the controllers, and stored in secrets that can be mounted directly into the /etc/cinder/cinder.conf.d directory. Content, including scripts, previously stored in a configmap are now stored in a corresponding secret. NOTES: - This patch deprecates the need for init containers, but they will be fully removed in a separate patch. - The switch from using configmaps to secrets affects a lot of function and variable names, and comments. This is cosmetic, and will be cleaned up in a separate patch. A total of 4 config snippet files are generated: - 00-config.conf contains global settings that are common to every cinder service, including ones that are derived from deployment secrets (e.g. transport URL, database password, etc.) - 01-config.conf contains the global customServiceConfig settings that apply to every cinder service. - 02-config.conf contains the customServiceConfig settings that are specific to each service. - 03-config.conf contains secrets specified by each service's customServiceConfigSecrets. The 00 and 01 files are generated by the top-level cinder controller, and each service's 02 and 03 files are generated by that service's controller. Each service's controller generates a secret that contains all 4 files, and uses a volume mount to map them directly in the /etc/cinder/cinder.conf.d directory. Mounting the files directly in that directory eliminates the need for kolla to copy the files from a separate "merged" directory.
Init containers are no longer required now that the controllers fully maintain the each service's config files.
|
/retest |
This is a purely cosmetic change (nothing functional) to update and/or remove all references to configmaps now that everything is stored in secrets.
ASBishop
force-pushed
the
revamp-config-process
branch
from
ee097b8 to
47f9dc1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, ASBishop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ASBishop
pushed a commit
to ASBishop/cinder-operator
that referenced
this pull request
Mar 11, 2024
…rators/renovate/openstack-k8s-operators Update openstack-k8s-operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for cinder that's consistent with the Propose Service Bootstrap config design
This PR consists of 3 patches, the first of which contains the most technically relevant changes, followed by 2 more "cleanup" patches. When reviewing the first patch, if you see some "cruft" that should be cleaned up, bear in mind it might be handled in one of the subsequent patches.