Skip to content

Commit

Permalink
Remove notifications TODO
Browse files Browse the repository at this point in the history
This patch updates our global default configuration that had a TODO for
the cinder notifications to explicitly state that it is disabled by
default and that it's very easy to enable it.

This is an excerpt of what a human operator would need to add to enable
it:

```
apiVersion: core.openstack.org/v1beta1
kind: OpenStackControlPlane
spec:
  cinder:
    customServiceConfig: |
      [oslo_messaging_notifications]
      driver = messagingv2
      transport_url = {{ .TransportURL }}
```

Jira: #OSPRH-1613
  • Loading branch information
Akrog committed Feb 22, 2024
1 parent edc92f5 commit 75c0d13
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions templates/cinder/config/00-global-defaults.conf
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@ lock_path = /var/locks/openstack/os-brick
[oslo_concurrency]
lock_path = /var/locks/openstack/cinder

# TODO:
#[oslo_messaging_notifications]
#transport_url = rabbit://stackrabbit:[email protected]:5672/
#driver = messagingv2
# Notifications are disabled by default, can be enabled by setting the driver
# to messagingv2 at the top level cinder customServiceConfig
[oslo_messaging_notifications]
transport_url = {{ .TransportURL }}
driver = noop

[oslo_messaging_rabbit]
heartbeat_timeout_threshold=60
Expand Down

0 comments on commit 75c0d13

Please sign in to comment.