Skip to content

Commit

Permalink
enable service token role validation for all service tokens
Browse files Browse the repository at this point in the history
As part of adressing CVE-2023-2088 cinder was modifed to
require the service role to be present in service token when
calling the attachemtn api to modify attachments related to nova
instance. One recomendation of that CVE mitigration discussions
was that all services shoudl enabel the service token role validation
by default. This change simplely enabled that by setting
[keystone_authtoken]/service_token_roles_required = true

Related: OSPRH191
  • Loading branch information
SeanMooney committed Sep 15, 2023
1 parent 27ac165 commit 6197bfa
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions templates/cinderapi/config/01-service-defaults.conf
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
[DEFAULT]
log_file = {{ .LogFile }}

[keystone_authtoken]
# This is part of hardening related to CVE-2023-2088
# when enabled the service token user must have the service role to be considered valid.
# cinder already checks for this, explicitly in the case of the attchment API even when
# this is not enforced for all service token validation.
service_token_roles_required = true

0 comments on commit 6197bfa

Please sign in to comment.