-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ee image var to RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT #614
Conversation
ee-runner image env var got changed to RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT var by openstack-k8s-operators/openstack-ansibleee-operator#226. We need to update the same to update the proper edpm image during deployment. Signed-off-by: Chandan Kumar <[email protected]>
Depends-On: openstack-k8s-operators/ci-framework#614 Signed-off-by: Chandan Kumar <[email protected]>
/approve since the other patch is already in, we'd better get that one in asap. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/474b9fecc1bb417089ed4a81985860d2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 58s |
This change depends-on #615 which itself depends-on openstack-k8s-operators/openstack-operator#493 |
recheck |
@@ -45,5 +45,5 @@ | |||
cifmw_edpm_prepare_update_os_containers: true | |||
cifmw_set_openstack_containers_operator_name: openstack-ansibleee | |||
cifmw_set_openstack_containers_overrides: | |||
ANSIBLEEE_IMAGE_URL_DEFAULT: "{{ ansibleee_runner_img }}" | |||
RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT: "{{ ansibleee_runner_img }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner, viroel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/03ffaebf70cf4ea4aa7de5167805436d ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 06s |
recheck |
ee-runner image env var got changed to RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT var by
openstack-k8s-operators/openstack-ansibleee-operator#226.
We need to update the same to update the proper edpm image during deployment.
As a pull request owner and reviewers, I checked that: