Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ee image var to RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT #614

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Sep 28, 2023

ee-runner image env var got changed to RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT var by
openstack-k8s-operators/openstack-ansibleee-operator#226.

We need to update the same to update the proper edpm image during deployment.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

ee-runner image env var got changed to RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT
var by
openstack-k8s-operators/openstack-ansibleee-operator#226.

We need to update the same to update the proper edpm image during
deployment.

Signed-off-by: Chandan Kumar <[email protected]>
@openshift-ci openshift-ci bot requested review from dasm and frenzyfriday September 28, 2023 10:00
raukadah added a commit to openstack-k8s-operators/edpm-ansible that referenced this pull request Sep 28, 2023
@cjeanner
Copy link
Collaborator

/approve
/lgtm

since the other patch is already in, we'd better get that one in asap.

@openshift-ci openshift-ci bot added the lgtm label Sep 28, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/474b9fecc1bb417089ed4a81985860d2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 10m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 47s
✔️ noop SUCCESS in 0s
podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 1h 05m 15s

@dasm
Copy link
Contributor

dasm commented Sep 28, 2023

This change depends-on #615 which itself depends-on openstack-k8s-operators/openstack-operator#493

@viroel
Copy link
Collaborator

viroel commented Sep 29, 2023

recheck

@@ -45,5 +45,5 @@
cifmw_edpm_prepare_update_os_containers: true
cifmw_set_openstack_containers_operator_name: openstack-ansibleee
cifmw_set_openstack_containers_overrides:
ANSIBLEEE_IMAGE_URL_DEFAULT: "{{ ansibleee_runner_img }}"
RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT: "{{ ansibleee_runner_img }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viroel
Copy link
Collaborator

viroel commented Sep 29, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/03ffaebf70cf4ea4aa7de5167805436d

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 06s
podified-multinode-edpm-deployment-crc TIMED_OUT in 3h 09m 48s
✔️ noop SUCCESS in 0s
podified-multinode-edpm-e2e-nobuild-tagged-crc TIMED_OUT in 3h 08m 36s

@cjeanner
Copy link
Collaborator

recheck

@openshift-merge-robot openshift-merge-robot merged commit 2e56083 into main Sep 29, 2023
@openshift-merge-robot openshift-merge-robot deleted the ee_operator branch September 29, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants