Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider that the zuul executor may be an IP #2607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablintino
Copy link
Collaborator

@pablintino pablintino commented Dec 16, 2024

Exposed a variable to pass the API endpoint without computing it too.

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pablintino. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft December 16, 2024 15:21
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

{{
zuul.executor.hostname
if (zuul.executor.hostname is ansible.utils.ip) else
(zuul.executor.hostname | split('.'))[1:] | join('.'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last parantheses must be removed?

AnsibleError: template error while templating string: unexpected ')'. String: {{ zuul.executor.hostname if (zuul.executor.hostname is ansible.utils.ip) else (zuul.executor.hostname | split('.'))[1:] | join('.')) }}. unexpected ')'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's wrong, thanks for the correction.

Exposed a variable to pass the API endpoint without computing it too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants