-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider that the zuul executor may be an IP #2607
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the PR! ❤️ |
ea40d7d
to
ef8fa80
Compare
ci/playbooks/multinode-autohold.yml
Outdated
{{ | ||
zuul.executor.hostname | ||
if (zuul.executor.hostname is ansible.utils.ip) else | ||
(zuul.executor.hostname | split('.'))[1:] | join('.')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last parantheses must be removed?
AnsibleError: template error while templating string: unexpected ')'. String: {{ zuul.executor.hostname if (zuul.executor.hostname is ansible.utils.ip) else (zuul.executor.hostname | split('.'))[1:] | join('.')) }}. unexpected ')'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's wrong, thanks for the correction.
Exposed a variable to pass the API endpoint without computing it too.
511d5f9
to
2fed770
Compare
Exposed a variable to pass the API endpoint without computing it too.