-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test_operator] Common default values for container images #2594
[test_operator] Common default values for container images #2594
Conversation
Thanks for the PR! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eduolivares if we want to keep this in the defaults
can you update the README.md
please?
Otherwise looks good to me!:) 👍
Also, cc @eshulman2 Do you think Ella this will break your PR? -> #2374 I think we should wait with merging this before Ella tells us her opinion. |
fe3aa32
to
9334840
Compare
9334840
to
ed9296a
Compare
I have taken a look at #2374 and wow, it's a big change. |
ed9296a
to
995bf41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Only one small change request in the README as the newly introduced parameters cifmw_test_operator_default_*
can not be overridden inside of cifmw_test_operator_stages
.
test-operator currently supports 4 test frameworks: tempest, tobiko, horizontests and ansibletests. The relevant variables required to download their corresponding container images had to be configured separately, but usually were configured with common values. With this PR, default values for registry, namespace and tag can be configured and they apply to the 4 test frameworks.
995bf41
to
e5b89b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e1ced0240524448ab8cda3263320b790 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 52s |
recheck |
5731e27
into
openstack-k8s-operators:main
test-operator currently supports 4 test frameworks: tempest, tobiko, horizontests and ansibletests. The relevant variables required to download their corresponding container images had to be configured separately, but usually were configured with common values. With this PR, default values for registry, namespace and tag can be configured and they apply to the 4 test frameworks.