Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kustomize_deploy] Make wait conditions optional #2578

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablintino
Copy link
Collaborator

In some ocassions, like when applying more than one nodesets the user may not want to wait for the first one to be applied and wait for all of them at once when all are applied.
This change is about not forcing the user, for no reason, to run a command to wait for a condition after some oc apply has been done.

In some ocassions, like when applying more than one nodesets the user
may not want to wait for the first one to be applied and wait for all of
them at once when all are applied.
This change is about not forcing the user, for no reason, to run a
command to wait for a condition after some `oc apply` has been done.
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pablintino. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft November 28, 2024 15:48
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant