Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shiftstack]Enable the option to run the role isolated #2572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[shiftstack]Enable the option to run the role isolated #2572

wants to merge 1 commit into from
+13 −1

Conversation

rlobillo
Copy link
Contributor

@rlobillo rlobillo commented Nov 26, 2024 •
edited
Loading

In order to allow users to run the shiftstack role without being part of
the full reproducer playbook, below changes are needed:

  • Add missing kubeconfig param
  • Load .bashrc while running the ansible-navigator. That's needed
    for reading the envvars that will be used for writting the junit report.
  • Enable the option to exclude artifacts to be gathered.

@github-actions github-actions bot marked this pull request as draft November 26, 2024 20:54
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8443b2c38ce44d97ae97d76c20041d8d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 33m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 43s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 53s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 27s
✔️ build-push-container-cifmw-client SUCCESS in 36m 55s
✔️ cifmw-molecule-shiftstack SUCCESS in 14m 08s

@pablintino
Copy link
Collaborator

recheck

@rlobillo rlobillo force-pushed the fix-kubeconfig branch 2 times, most recently from 80c1854 to 3fd2d2e Compare November 29, 2024 14:02
@rlobillo rlobillo changed the title [shiftstack]add missing kubeconfig param [shiftstack]Enable the option to run the role isolated Nov 29, 2024
@rlobillo
Copy link
Contributor Author

Tested on https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/59184/rehearse-59184-periodic-ci-shiftstack-ci-release-4.16-e2e-openstack-rhoso/1862537103728971776

@rlobillo rlobillo marked this pull request as ready for review November 29, 2024 18:20
eurijon
eurijon reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@eurijon eurijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! just added a minor comment

roles/shiftstack/defaults/main.yml Outdated Show resolved Hide resolved
@eurijon
Copy link
Contributor

eurijon commented Dec 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a7c2630947b14bcd92d78efe01850f47

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 39s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 55s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 35s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 12s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 51s
✔️ build-push-container-cifmw-client SUCCESS in 22m 19s
✔️ cifmw-molecule-shiftstack SUCCESS in 16m 26s

@rlobillo
Copy link
Contributor Author

rlobillo commented Dec 5, 2024

recheck

@rlobillo
Copy link
Contributor Author

rlobillo commented Dec 7, 2024

recheck

@rlobillo rlobillo marked this pull request as draft December 16, 2024 10:21
@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlobillo rlobillo marked this pull request as ready for review December 18, 2024 15:06
@eurijon
Copy link
Contributor

eurijon commented Dec 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@rlobillo
[shiftstack]Enable the option to run the role isolated
92c8ddc 
In order to allow users to run the shiftsatck role without being part of
the whole reproducer, below changes are needed:

- Add missing kubeconfig param
- Load .bashrc whle running the ansible-navigator. That's needed
for reading the envvars that will be used for writting the junit report.
- Enable the option to exclude artifacts to be gathered.
@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

New changes are detected. LGTM label has been removed.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a21054fc0fb140cb9a42e66f68f8bf7f

✔️ openstack-k8s-operators-content-provider SUCCESS in 31m 58s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 6m 11s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 55s
✔️ build-push-container-cifmw-client SUCCESS in 36m 51s
✔️ cifmw-molecule-shiftstack SUCCESS in 15m 25s

@rlobillo
Copy link
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurijon eurijon eurijon left review comments

@pablintino pablintino Awaiting requested review from pablintino

Assignees

@eurijon eurijon

Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlobillo @pablintino @eurijon