Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nova multiplecells nodeset templates #2423

Conversation

jamepark4
Copy link
Contributor

@jamepark4 jamepark4 commented Oct 3, 2024

Currently working with [1] to allow for deployment of two nodesets with each nodeset corresponding with a respective cell.

[1] openstack-k8s-operators/architecture#401

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jamepark4 jamepark4 force-pushed the multicell_scenario_template branch 5 times, most recently from 0769232 to fc7bfff Compare October 9, 2024 13:37
@jamepark4 jamepark4 force-pushed the multicell_scenario_template branch from fc7bfff to 8b7b01d Compare October 23, 2024 16:52
Copy link

github-actions bot commented Nov 8, 2024

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@jamepark4 jamepark4 removed the Stale label Nov 8, 2024
@jamepark4 jamepark4 changed the title [WIP] Add nova multiplecells nodeset templates Add nova multiplecells nodeset templates Nov 18, 2024
@jamepark4 jamepark4 marked this pull request as ready for review November 18, 2024 18:05
@jamepark4 jamepark4 requested a review from pablintino November 18, 2024 18:40
@jamepark4 jamepark4 force-pushed the multicell_scenario_template branch from 8b7b01d to 0b4bde8 Compare November 25, 2024 14:46
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, to get the docs ci job to pass you need to rebase to catch: #2526

Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eab8350 into openstack-k8s-operators:main Dec 11, 2024
4 checks passed
softwarefactory-project-zuul bot added a commit to openstack-k8s-operators/architecture that referenced this pull request Dec 16, 2024
Add nova 3 cell DT

Standard deployments currently deploy cell0 and cell1.  Create a DT that deploys cell0, cell1, and cell2.
Depends-On: openstack-k8s-operators/ci-framework#2423

Reviewed-by: Harald <[email protected]>
Reviewed-by: jamepark4 <[email protected]>
Reviewed-by: Balazs Gibizer <[email protected]>
Reviewed-by: Bogdan Dobrelya
Reviewed-by: Andrew Bays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants