Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve adoption coverage for openstack-operator #2402

Merged

Conversation

jistr
Copy link
Contributor

@jistr jistr commented Sep 27, 2024

This should help prevent breakages like [1].

[1] openstack-k8s-operators/openstack-operator#1103

Until now we ran the adoption job only when bumping the component operators, but we should run it also when we change the interface (CRDs) or the behavior of the openstack-operator itself.

Related: OSPCIX-504

This should help prevent breakages like [1].

openstack-k8s-operators/openstack-operator#1103

Related: OSPCIX-504
@github-actions github-actions bot marked this pull request as draft September 27, 2024 11:06
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2024
@github-actions github-actions bot marked this pull request as draft September 27, 2024 13:03
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/580687c84a92488db7dd6d32520f828a

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 39m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 53s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 54s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 43m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 07s
✔️ cifmw-pod-zuul-files SUCCESS in 3m 50s
✔️ build-push-container-cifmw-client SUCCESS in 31m 01s

@cescgina
Copy link
Contributor

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit b4fe9f2 into openstack-k8s-operators:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants