-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve adoption coverage for openstack-operator #2402
Improve adoption coverage for openstack-operator #2402
Conversation
This should help prevent breakages like [1]. openstack-k8s-operators/openstack-operator#1103 Related: OSPCIX-504
Thanks for the PR! ❤️ |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the PR! ❤️ |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/580687c84a92488db7dd6d32520f828a ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 39m 49s |
recheck |
b4fe9f2
into
openstack-k8s-operators:main
This should help prevent breakages like [1].
[1] openstack-k8s-operators/openstack-operator#1103
Until now we ran the adoption job only when bumping the component operators, but we should run it also when we change the interface (CRDs) or the behavior of the openstack-operator itself.
Related: OSPCIX-504