Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include install-certs dataplane service #1409

Merged

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Apr 5, 2024

It's required with tls enabled, [1] already enabled tls by default so need to include the install-certs service before the services requiring the certs.
The issue should be visible once dataplane-operator is updated[2] or tlsEnabled flag is explicitly set in the nodeset.

Also update nova-custom-ceph dataplane service to
include missing tls params.

[1] openstack-k8s-operators/dataplane-operator#754
[2] openstack-k8s-operators/openstack-operator#732

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/be344d47307548bb8b8cffcdcbc8726f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 49s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 18m 56s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 32m 46s
✔️ noop SUCCESS in 0s
✔️ cifmw-molecule-hci_prepare SUCCESS in 3m 58s

It's required with tls enabled, [1] already enabled tls by default
so need to include the install-certs service before the services
requiring the certs.
The issue should be visible once dataplane-operator is updated[2]
or tlsEnabled flag is explicitly set in the nodeset.

Also update nova-custom-ceph dataplane service to
include missing tls params.

[1] openstack-k8s-operators/dataplane-operator#754
[2] openstack-k8s-operators/openstack-operator#732
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/06ab4b9a50934d5da4476b3d8629b7ec

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 14s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 18m 03s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 38m 17s
✔️ noop SUCCESS in 0s
✔️ cifmw-molecule-hci_prepare SUCCESS in 5m 11s

@tosky tosky requested a review from viroel April 6, 2024 12:08
@tosky
Copy link
Contributor

tosky commented Apr 6, 2024

/lgtm

@raukadah
Copy link
Contributor

raukadah commented Apr 8, 2024

/retest

@karelyatin
Copy link
Contributor Author

recheck galaxy issue

@cjeanner
Copy link
Contributor

cjeanner commented Apr 8, 2024

/approve

We'll need something similar in the architecture repository I guess. This affects install_yamls based deployments only, as launched in upstream CI.

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fd4c2f8 into openstack-k8s-operators:main Apr 8, 2024
8 checks passed
@tosky
Copy link
Contributor

tosky commented Apr 8, 2024

@cjeanner architecture repo already got openstack-k8s-operators/architecture#165

@karelyatin karelyatin deleted the install-certs branch April 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants