-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include install-certs dataplane service #1409
Include install-certs dataplane service #1409
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/be344d47307548bb8b8cffcdcbc8726f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 49s |
It's required with tls enabled, [1] already enabled tls by default so need to include the install-certs service before the services requiring the certs. The issue should be visible once dataplane-operator is updated[2] or tlsEnabled flag is explicitly set in the nodeset. Also update nova-custom-ceph dataplane service to include missing tls params. [1] openstack-k8s-operators/dataplane-operator#754 [2] openstack-k8s-operators/openstack-operator#732
1ae990d
to
e7571db
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/06ab4b9a50934d5da4476b3d8629b7ec ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 14s |
/lgtm |
/retest |
recheck galaxy issue |
/approve We'll need something similar in the architecture repository I guess. This affects install_yamls based deployments only, as launched in upstream CI. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fd4c2f8
into
openstack-k8s-operators:main
@cjeanner architecture repo already got openstack-k8s-operators/architecture#165 |
It's required with tls enabled, [1] already enabled tls by default so need to include the install-certs service before the services requiring the certs.
The issue should be visible once dataplane-operator is updated[2] or tlsEnabled flag is explicitly set in the nodeset.
Also update nova-custom-ceph dataplane service to
include missing tls params.
[1] openstack-k8s-operators/dataplane-operator#754
[2] openstack-k8s-operators/openstack-operator#732
As a pull request owner and reviewers, I checked that: