[Test operator] Fix skiplist generation #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing here: https://review.rdoproject.org/r/c/testproject/+/52696 |
The test_operator_cr is a copy of the cifmw_test_operator_tempest_config therefore it does not contain a reference to the cifmw_test_operator_exclude_list variable. Because of that, we have to specify the value for excludeList directly in the test_operator_cr.
lpiwowar
force-pushed
the
fix/generate-skiplist
branch
from
ac12980 to
e672194
Compare
1 task
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d01cdc3
into
openstack-k8s-operators:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_operator_cr is a copy of the cifmw_test_operator_tempest_config therefore it does not contain a reference to the cifmw_test_operator_exclude_list variable.
Because of that, we have to specify the value for excludeList directly in the test_operator_cr.
As a pull request owner and reviewers, I checked that: