Add TLS Support to barbican operator #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakwetu
requested review from
xek,
olliewalsh,
dmendiza,
stuggi and
Deydra71
vakwetu
force-pushed
the
add_tls
branch
3 times, most recently
from
d58b268 to
8416f11
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vakwetu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d34dh0r53
added a commit
to d34dh0r53/openstack-operator
that referenced
this pull request
Jan 16, 2024
Creates certs for k8s service of the service operator when
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/barbican-operator#55
Jira: OSPRH-2349
stuggi
reviewed
Jan 29, 2024
| } | ||
| } | ||
|
|
||
| // TODO(alee) should this validation occur in an if statement? what happens when tls is not enabled? |
There was a problem hiding this comment.
certsHash would be calculated for the empty certHashes https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/tls/tls.go#L166 as both endpoints are not enabled for tls
| instance.Status.Conditions.MarkTrue(condition.ServiceConfigReadyCondition, condition.ServiceConfigReadyMessage) | ||
|
|
||
| // TODO(alee) Figure out how serviceLabels are used and what must be in them |
There was a problem hiding this comment.
serviceLabels is basically the base labels to be set on all resources created by the controller to easy query/identify them. depending on which resource is created they get extended with additional, e.g. k8s svc will have the serviceLabels + the endpoint identifier.
| @@ -634,9 +696,38 @@ func (r *BarbicanAPIReconciler) reconcileNormal(ctx context.Context, instance *b | |||
| return ctrlResult, nil | |||
| } | |||
|
|
|||
| Log.Info(fmt.Sprintf("[API] Getting input hash '%s'", instance.Name)) | |||
|
/wip |
These tests will determine the functionality of TLSe within the barbican-operator.
|
/lgtm |
openshift-merge-bot
bot
merged commit 3b43913
into
openstack-k8s-operators:main
6 checks passed
d34dh0r53
added a commit
to d34dh0r53/openstack-operator
that referenced
this pull request
Feb 12, 2024
spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal
endpoints, this has to be set for each of them for, like:
~~~
customServiceConfig: |
[keystone_authtoken]
insecure = true
[placement]
insecure = true
[neutron]
insecure = true
[glance]
insecure = true
[cinder]
insecure = true
~~~
Depends-On: openstack-k8s-operators/lib-common#428
Depends-On: openstack-k8s-operators#620
Depends-On: openstack-k8s-operators/barbican-operator#55
Jira: OSPRH-2349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the changes needed to enable TLS-E in barbican.