Add configurable API Timeout #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to allow configure timeouts for HAProxy and Apache. Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
requested review from
xek,
d34dh0r53 and
dmendiza
and removed request for
olliewalsh
Deydra71
commented
Jan 3, 2025
| @@ -722,6 +722,9 @@ func (r *BarbicanReconciler) apiDeploymentCreateOrUpdate(ctx context.Context, in | |||
| apiSpec.NodeSelector = instance.Spec.NodeSelector | |||
| } | |||
|
|
|||
| // Note: The top-level .spec.apiTimeout ALWAYS overrides .spec.barbicanAPI.apiTimeout | |||
There was a problem hiding this comment.
This follows other operators behavior
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71, vakwetu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 02efac8
into
openstack-k8s-operators:main
6 checks passed
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Jan 6, 2025
Depends-On: openstack-k8s-operators/barbican-operator#197 Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Jan 6, 2025
Depends-On: openstack-k8s-operators/barbican-operator#197 Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Jan 9, 2025
Depends-On: openstack-k8s-operators/barbican-operator#197 Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Jan 13, 2025
Depends-On: openstack-k8s-operators/barbican-operator#197 Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
added a commit
to Deydra71/openstack-operator
that referenced
this pull request
Jan 15, 2025
Depends-On: openstack-k8s-operators/barbican-operator#197 Signed-off-by: Veronika Fisarova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to allow configure timeouts for HAProxy and Apache.
Jira: https://issues.redhat.com/browse/OSPRH-10964