-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests for HSM Support #190
base: main
Are you sure you want to change the base?
Functional tests for HSM Support #190
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauricioharley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hold-the-node Signed-off-by: Mauricio Harley <[email protected]> Co-authored-by: Ade Lee <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
6d5561c
to
19dd70c
Compare
Signed-off-by: Mauricio Harley <[email protected]>
19dd70c
to
dca4e9b
Compare
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
be9984d
to
9cb2c87
Compare
Signed-off-by: Mauricio Harley <[email protected]>
9cb2c87
to
8c4c86f
Compare
/retest |
1 similar comment
/retest |
@mauricioharley: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ContainSubstring("dummy-data")) | ||
}) | ||
|
||
It("Verifies if Chrystoki.conf and 00-default.conf have the right contents.", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably repeat this test for the BarbicanAPIConfigSecret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start generally. Just a few suggestions of things to add.
Functional tests for the Luna HSM model support.