Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests for HSM Support #190

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mauricioharley
Copy link
Contributor

Functional tests for the Luna HSM model support.

Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauricioharley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Mauricio Harley added 2 commits December 2, 2024 19:37
hold-the-node
Signed-off-by: Mauricio Harley <[email protected]>
Co-authored-by: Ade Lee <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
@xek xek force-pushed the luna_functional_tests branch from 6d5561c to 19dd70c Compare December 3, 2024 08:30
@xek xek marked this pull request as draft December 3, 2024 08:31
gibizer
gibizer previously requested changes Dec 3, 2024
hack/crd-schema-checker.sh Outdated Show resolved Hide resolved
api/v1beta1/common_types.go Outdated Show resolved Hide resolved
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
@gibizer gibizer dismissed their stale review December 9, 2024 15:56

My comments were addressed

Signed-off-by: Mauricio Harley <[email protected]>
@mauricioharley
Copy link
Contributor Author

/retest

1 similar comment
@mauricioharley
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Dec 17, 2024

@mauricioharley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/barbican-operator-build-deploy-kuttl 8c4c86f link true /test barbican-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ContainSubstring("dummy-data"))
})

It("Verifies if Chrystoki.conf and 00-default.conf have the right contents.", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably repeat this test for the BarbicanAPIConfigSecret

Copy link
Contributor

@vakwetu vakwetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start generally. Just a few suggestions of things to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants