Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BGP] Replace worker-3 NAD from host-device to macvlan #466

Conversation

eduolivares
Copy link
Contributor

We implemented a solution to connect test pods running in worker-3 to the provider network using a host-device NAD. This has been working fine while only one test pod ran simultaneously.
With the new feature added to tobiko to run a tobiko-ping pod in parallel with the usual tobiko pod, attaching several pods to that NAD is necessary.
This PR modified the BGP configuration so that the mentioned host-device NAD is replaced with a macvlan NAD that allows multiple connections.

We implemented a solution to connect test pods running in worker-3 to
the provider network using a host-device NAD. This has been working fine
while only one test pod ran simultaneously.
With the new feature added to tobiko to run a tobiko-ping pod in
parallel with the usual tobiko pod, attaching several pods to that NAD
is necessary.
This PR modified the BGP configuration so that the mentioned host-device
NAD is replaced with a macvlan NAD that allows multiple connections.
@ccamposr
Copy link

/lgtm

Copy link

openshift-ci bot commented Dec 18, 2024

@ccamposr: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eduolivares eduolivares added ready-review Request is ready to be reviewed and removed do-not-merge/hold labels Dec 18, 2024
@abays abays added the testing-complete Testing is completed and ready for final reviews label Dec 18, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, eduolivares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8b8d0cf9ef7e414197d36def8d028ab0

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bgp_dt01 SUCCESS in 3m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b893b45 into openstack-k8s-operators:main Dec 18, 2024
7 checks passed
@eduolivares eduolivares deleted the bgp-worker-3-interface-changes branch December 18, 2024 16:10
@eduolivares
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@eduolivares: new pull request created: #468

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ready-review Request is ready to be reviewed testing-complete Testing is completed and ready for final reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants