Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable extra mount in uni02beta" #356

Conversation

tosky
Copy link
Contributor

@tosky tosky commented Aug 5, 2024

It seems glance/NFS (or better, the combination of glance/NFS and
cinder/NFS) is stable enough, at least when used with different shares,
so that it can be reenabled.

This reverts commit 43ba5f8.

Copy link

openshift-ci bot commented Aug 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fultonj fultonj self-requested a review August 6, 2024 13:30
@tosky tosky force-pushed the unibeta-reenable-extramount branch from 8a01ede to 2e8ae7f Compare December 12, 2024 15:39
It seems glance/NFS (or better, the combination of glance/NFS and
cinder/NFS) is stable enough, at least when used with different shares,
so that it can be reenabled.

This reverts commit 43ba5f8.
@tosky tosky force-pushed the unibeta-reenable-extramount branch from 2e8ae7f to 3ef2648 Compare December 13, 2024 16:28
@tosky tosky changed the title DNM WIP Revert "Disable extra mount in uni02beta" Revert "Disable extra mount in uni02beta" Dec 13, 2024
@tosky tosky marked this pull request as ready for review December 13, 2024 16:29
@tosky tosky requested a review from fmount December 13, 2024 16:35
@fmount
Copy link
Contributor

fmount commented Dec 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@abays abays added the testing-complete Testing is completed and ready for final reviews label Dec 16, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, tosky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8ef1835410e74a7c94450533c78c7f11

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni02beta SUCCESS in 3m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2da816a into openstack-k8s-operators:main Dec 16, 2024
7 checks passed
@sdatko
Copy link
Contributor

sdatko commented Dec 16, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@sdatko: only openstack-k8s-operators org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdatko
Copy link
Contributor

sdatko commented Dec 16, 2024

:-(

@tosky
Copy link
Contributor Author

tosky commented Dec 16, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@tosky: new pull request created: #464

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

softwarefactory-project-zuul bot added a commit that referenced this pull request Dec 16, 2024
…56-to-18.0-fr1

[18.0-fr1] Revert "Disable extra mount in uni02beta"

This is an automated cherry-pick of #356
/assign tosky

Reviewed-by: Andrew Bays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm testing-complete Testing is completed and ready for final reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants