Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uni02beta] Reenable file/NFS for glance #344

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[uni02beta] Reenable file/NFS for glance #344

merged 1 commit into from
Jul 25, 2024

Conversation

tosky
Copy link
Contributor

@tosky tosky commented Jul 24, 2024

Most of the issues described in https://issues.redhat.com/browse/OSPRH-7396 were addressed, at least on the controlplane side. As glance is mostly concerned with that part, it should work again.

This is a revert of

  • b917c31 [uni02beta] Drop NFS from Glance
  • 87d9931 Set UNI-Beta to replica: 1

@tosky
[uni02beta] Reenable file/NFS for glance
d06ac9f 
Most of the issues described in https://issues.redhat.com/browse/OSPRH-7396
were addressed, at least on the controlplane side. As glance is mostly
concerned with that part, it should work again.

This is a revert of
* b917c31 [uni02beta] Drop NFS from Glance
* 87d9931 Set UNI-Beta to replica: 1
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tosky tosky marked this pull request as ready for review July 25, 2024 08:50
@openshift-ci openshift-ci bot requested review from fultonj and raukadah July 25, 2024 08:50
@arxcruz
Copy link
Contributor

arxcruz commented Jul 25, 2024

/approve
/lgtm

@tosky
Copy link
Contributor Author

tosky commented Jul 25, 2024

Tested internally - it works again (thanks to the uniqueness of the pod names for glance-api, I guess)

@openshift-ci openshift-ci bot added the lgtm label Jul 25, 2024
@abays abays added the testing-complete Testing is completed and ready for final reviews label Jul 25, 2024
abays
abays approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, arxcruz, tosky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b4762d52150240e5be5de1ac805b7077

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni02beta SUCCESS in 4m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7e113ed into openstack-k8s-operators:main Jul 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@fultonj fultonj Awaiting requested review from fultonj

@raukadah raukadah Awaiting requested review from raukadah

Assignees

@arxcruz arxcruz

@abays abays

Labels
approved lgtm testing-complete Testing is completed and ready for final reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tosky @arxcruz @abays