Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Cinder wait for DB writes on reads" #297

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Revert "Cinder wait for DB writes on reads" #297

merged 1 commit into from
Jun 18, 2024

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jun 18, 2024

The openstack-k8s-operators/mariadb-operator#229 switched the mariadb-operator to deploy in Active/Passive mode per default, instead of multimaster.

So we should no longer set mysql_wsrep_sync_wait.

Related PR: openstack-k8s-operators/cinder-operator#401

This reverts commit cf4f3f6.

@Akrog
Revert "Cinder wait for DB writes on reads"
ac0833d 
The openstack-k8s-operators/mariadb-operator#229 switched the
mariadb-operator to deploy in Active/Passive mode per default, instead
of multimaster.

So we should no longer set `mysql_wsrep_sync_wait`.

This reverts commit cf4f3f6.
@openshift-ci openshift-ci bot requested review from abays and fultonj June 18, 2024 13:24
fultonj
fultonj approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://review.rdoproject.org/zuul/buildset/42ae79fa99a742d7a4fd680d9eebb466

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bgp SUCCESS in 4m 34s
✔️ rhoso-architecture-validate-bgp_dt01 SUCCESS in 4m 41s
✔️ rhoso-architecture-validate-hci SUCCESS in 4m 53s
✔️ rhoso-architecture-validate-ovs-dpdk SUCCESS in 4m 40s
✔️ rhoso-architecture-validate-ovs-dpdk-sriov SUCCESS in 4m 34s
✔️ rhoso-architecture-validate-pidone SUCCESS in 4m 33s
✔️ rhoso-architecture-validate-sriov SUCCESS in 4m 41s
✔️ rhoso-architecture-validate-uni01alpha SUCCESS in 4m 49s
✔️ rhoso-architecture-validate-uni02beta SUCCESS in 4m 37s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 4m 49s
✔️ rhoso-architecture-validate-uni05epsilon SUCCESS in 4m 42s
✔️ rhoso-architecture-validate-uni06zeta SUCCESS in 4m 29s
✔️ rhoso-architecture-validate-uni07eta SUCCESS in 4m 59s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aba2e2e into openstack-k8s-operators:main Jun 18, 2024
7 checks passed
@tosky tosky mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj approved these changes

@abays abays Awaiting requested review from abays

Assignees

@fultonj fultonj

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akrog @fultonj