-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[va-hci] Remove references to edpm images #204
[va-hci] Remove references to edpm images #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with VA1. Deployment succeeded and Tempest passed.
/lgtm
/lgtm The defaults for edpm images is managed in dataplane-operator, overriding just the edpm images and not the control plane(specifically OVN images atleast) can cause issues as mentioned in https://issues.redhat.com/browse/OSPRH-1504 . The new way for managing the both control plane/data plane is with OpenStackVersion CR. @eduolivares please drop WIP from commit |
b620756
to
c1eb305
Compare
WIP removed from both commit and PR messages. |
/lgtm |
Please wait to merge this until after #197 is merged, and then kindly rebase. We're splitting the EDPM deployment and the file modified in this PR will no longer exist under the current path. |
Default image versions obtained from the dataplane-operator will be used instead
c1eb305
to
6ec959f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just throwing needs-info on this to make sure there is no issue across other VAs or DTs as they should all remain in sync. |
It seems no other VAs/DTs specify the EDPM images used:
I am working on a PR where EDPM images were specified too, but I removed them yesterday: So, I think all VAs and DTs are synchronized. |
Default image versions obtained from the dataplane-operator will be used instead