Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approved_message_prefixes should include empty messages #436

Open
sajoupa opened this issue Mar 15, 2021 · 2 comments
Open

approved_message_prefixes should include empty messages #436

sajoupa opened this issue Mar 15, 2021 · 2 comments

Comments

@sajoupa
Copy link

sajoupa commented Mar 15, 2021 •
edited
Loading

The cs:ubuntu charm no longer displays a messages ('ready', 'Ready', or 'Unit is ready').
Its stable state is now 'active' / ''.
This makes zaza wait for ever, until it times out. zaza expects:

approved_message_prefixes = ['ready', 'Ready', 'Unit is ready']

This fixes it:

approved_message_prefixes = ['ready', 'Ready', 'Unit is ready', '']
@ajkavanagh
Copy link
Collaborator

This probably needs to be done in the tests.yaml - see here - to solve the problem on an as needed basis.

Setting it to allow '' by default might be too permissive for the library, so I'm -1 on this idea. Other thoughts welcome.

@sajoupa
Copy link
Author

sajoupa commented Mar 16, 2021

Hi,

I think that active/"" is the new default behavior for charms.
I filed canonical/charm-ubuntu#24 to get a confirmation.
If it is indeed the case, then the value '' should be in the default list, not manually added in tests.yaml.

Thanks.

coreycb pushed a commit to coreycb/zaza that referenced this issue Oct 17, 2023
@lourot
Merge pull request openstack-charmers#436 from xavpaice/bug/1897809
15add17 
Add NRPE check tests for Designate
sudeephb pushed a commit to canonical/charm-storage-connector that referenced this issue Dec 7, 2023
tests: make unit and func tests pass again
17b428f 
This changes are mostly working on the test codes to make sure they are
passing for the upcoming jammy support. In addition to that, it removes some
old workarounds that are not needed anymore.

There's still one open issue about the functional tests. See below.

Since this is a big change, here is a summary of changes.

Makefile:
  - remove workaround for the closed issue[0] where symlinks breaking
    charm push
  - introduce standard rename.sh

tests/unit:
  - mock a bunch of stuff that were trying to modify system files/dirs

tests/functional:
  - remove workaround for the closed issue[1] where zaza was not
    respecting local_overlay_enabled key
  - fix the issue where zaza waits for ubuntu charms indefinitely due to
    empty message[2]
  - add missing required config key in iscsi test
  - charmstore -> charmhub

src:
  - get rid of commented code in production
  - add missing quotes to a config.yaml default key

---

Currently open issues:
tests/functional:
  - focal-fc bundle is not running, probably needs special hardware
    judging by the constraint given in the bundle file. However it is not
    listed in gate or smoke bundles, so it is not blocking the release.

[0] canonical/charmcraft#109
[1] openstack-charmers/zaza#379
[2] openstack-charmers/zaza#436

Signed-off-by: Mert Kırpıcı <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajkavanagh @sajoupa