-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove setup-perl action from windows jobs #22555
Conversation
Windows runner have Perl preinstalled. https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sidenote: the default perl in the runner images drags in much of GCC onto the PATH, which is obviously a source of great fun on windows (and something that both upstream strawberry perl as well as GHA have refused to fix). It might ultimately be cleaner to depend on a less troublesome perl, even if it's part of the image. |
I'm not sure how the action |
Answering to myself. Actually, yes https://github.com/shogo82148/actions-setup-perl/blob/main/src/strawberry.ts#L78 but if you install |
If things work as in this PR, that's alright I guess. It was more of a heads-up about the idiosyncrasies of the built-in perl. |
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Merged to the master branch. Thank you. |
Windows runner have Perl preinstalled. https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tom Cosgrove <[email protected]> (Merged from #22555)
Windows runner have Perl preinstalled. https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tom Cosgrove <[email protected]> (Merged from openssl/openssl#22555) Signed-off-by: fly2x <[email protected]>
Windows runners have Perl preinstalled.
https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md
Checklist