Standardize font and font-size across all pages and components

[juliaferraioli]

This is totally my fault, and I think we need to revert it or figure out what our default size should be. Right now it looks a little disjointed with the text on the pages and text on the components.

[YC-Kwan]

Hi there, may I know what should do about this issue?

[juliaferraioli]

Hi @YC-Kwan, thanks for asking!

If you look at the bio text on our about page, the font and font color isn't set to what we use in the text above it.

For the data rendering, we probably want the div to have almost-black added to the class:

opensourcestories.org/layouts/about/list.html

Line 15 in e5d960d

<div class="team-person">

the h2 to have f3 fw1 lh-title added to the class:

opensourcestories.org/layouts/about/list.html

Line 16 in e5d960d

<h2>{{ .name }}, {{ .roles }}</h2>

and the p to have f5-l nested-copy-line-height added to the class:

opensourcestories.org/layouts/about/list.html

Line 17 in e5d960d

<p>{{ .bio }}</p>

There may be other areas on the site that you notice similar inconsistencies -- please let me know if this is an issue you'd like to take on!

[YC-Kwan]

Okay, thanks for the information but for the data rendering what does it mean to have almost-black in the class?

[juliaferraioli]

@YC-Kwan great question! almost-black is in our css:

opensourcestories.org/assets/ananke/css/opensourcestories.css

Line 9 in e5d960d

.almost-black {

It turns the font color nearly black, or #222222 if you prefer the hex.

[YC-Kwan]

Okay, so which mean need to add almost-black into <div class="team-person"> like <div class="team-person almost-black"> right?

[juliaferraioli]

@YC-Kwan that's correct!

[YC-Kwan]

Okay, thanks. Is it necessary to install Go and Hugo?

[juliaferraioli]

Generally, I think that's a good thing to do so that you can see how it works before submitting a PR.

[juliaferraioli]

Hi @YC-Kwan, are you still interested in this issue?

[VenkateshThoguta]

hi,im a beginner tp opensource projects.
i have done bunch of projects
i think i will be able to fix this good first issue
can u please assign me?

[VenkateshThoguta]

we can add f4 class to div of team-person class
so that we can fix the issue

[juliaferraioli]

Hi @VenkateshThoguta, happy to assign it to you!

[VenkateshThoguta]

I have made the changes in class in list.html in about section
Made a pull request
Kindly check

[VenkateshThoguta]

Made a change in class by adding f4 in about section in list.html and made a pull request Kindly check

…

On Mon, 19 Jun 2023, 02:23 julia ferraioli, ***@***.***> wrote: Assigned #49 <#49> to @VenkateshThoguta <https://github.com/VenkateshThoguta>. — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5R57DWD4RRFENUFMPPHJY3XL5TGHANCNFSM5TQ635HQ> . You are receiving this because you were assigned.Message ID: <opensourcestories/opensourcestories.org/issue/49/issue_event/9561973525@ github.com>

[juliaferraioli]

Hi @VenkateshThoguta, I actually don't see an open PR from you. Can you ensure you submitted it?

[VenkateshThoguta]

Sorry for the inconvenience Made PR now.....

…

On Tue, 20 Jun 2023, 01:55 julia ferraioli, ***@***.***> wrote: Hi @VenkateshThoguta <https://github.com/VenkateshThoguta>, I actually don't see an open PR from you. Can you ensure you submitted it? — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5R57DRNHB44PR26GSEPDPTXMCYT7ANCNFSM5TQ635HQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>