Improve member onboarding instructions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did consider the type field vs. URL tradeoff while working on #1. I'd rather keep the schema simple and do URL parsing. It shouldn't be that hard, and it's better for us to bear the burden than them. |
chadwhitacre
approved these changes
Aug 7, 2024
|
Doc changes look great, thanks @pimterry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are based on suggestions from @pimterry.
Another thing Tim mentioned was that, instead of just having URLs for each line item, we could have either
{ type: 'github', username 'vladh' }or{ type: 'other', url: 'https://example.com/receipts' }. The reasoning here is that if we have atypefield, we could automatically query totals from GitHub, easily get some statistics on the most used payment methods, and so on. We can already do this, less conveniently, by parsing the URLs. I'll leave this to @chadwhitacre to decide.