Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members: create mockup of grid-based page #279

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

vladh
Copy link
Member

@vladh vladh commented Dec 9, 2024

@chadwhitacre Were you thinking of something like this?

2024-12-09-14-37-05

@vladh vladh requested a review from chadwhitacre December 9, 2024 14:37
@chadwhitacre
Copy link
Contributor

Awesome start! 🥳

A few requests:

  • bump up the size of the company name just a touch
  • make the font size of the metadata smaller
  • add the date onboarded (that's available easily, I think?)
  • add a snippet from their marketing copy (below)

Feel free to merge this and follow up in new PRs.

sentry	We've always given back to the community and now we're happy to help other companies do the same through the Open Source Pledge.
sanity	We're joining the Open Source Pledge because we believe in supporting the open source projects and maintainers that our platform is built on.
herodevs	We believe it's essential to give back to the community that powers so much of our work.
zerodha	By joining the Open Source Pledge and sharing our journey, we hope to inspire other companies to take similar steps. 
antithesis	We rely heavily on the countless hours of work contributed by OSS maintainers worldwide.
stackblitz	We're happy to continue giving back to the Open Source community by joining the Open Source Pledge.
prefect	By supporting these projects, we're not just giving back—we're investing in the future of open source.
laravel	Participating in the Open Source Pledge is just one of the ways we continue to invest in the future of open source.
pydantic	For too long the open source ecosystem has been taken for granted. We're proud to be part of the movement to change that.
speakeasy	We've always supported the OSS projects that our platform is built on.
voidzero	We rely on many important dependencies and we love to give back.
astral	We're excited to establish a precedent for giving early and often.
platformatic	Contributing to open source projects fosters a strong, collaborative community, benefiting everyone involved.
scalar	Thanks to all the maintainers and contributors whose software we are privileged to use and build with.
pixee	We believe in Open Source! We leverage tools from the community and strive to give back when possible.
frontend-masters	Many maintainers have considered quitting due to burnout. We want to shine a light on this threat to open source.
emerge-tools	We try to give back to the open source community as much as we can through our own projects as well as sponsorships.
browserbase	We believe in the power of open source software and its impact on the growth of the tech community.
private-packagist	As open-source maintainers ourselves we wish to do our part in helping the entire ecosystem of open-source software thrive.
tideways	We want to make a public commitment on our various open source contributions.
val-town	Thanks so much to all the maintainers we depend on! We are so grateful for your work.
gitbutler	We believe that it's important to do what we can to support maintainers and help make the Open Source community sustainable.
vlt	We believe open source software is at the heart of modern businesses success.
rector	Rector is alive thanks to Open Source projects and the developers behind those projects.
keygen	Being built on top of Open Source, we strive to give back to the community whenever possible with our own Open Source projects as well as our funds.
buttondown	We—and you, even if you don't know it—would be nowhere without open source software.
httptoolkit	Like all modern software projects, we stand on the shoulders of a huge variety of other open-source components.
chieftools	We're joining the Open Source Pledge because our business is built on and with open-source software.

@chadwhitacre
Copy link
Contributor

Also let's use the same border-radius as on the card treatment on the profile pages:

image

@vladh
Copy link
Member Author

vladh commented Dec 9, 2024

@chadwhitacre What about now? I think having the roles on there is a nice touch.

2024-12-09-20-09-56

@vladh
Copy link
Member Author

vladh commented Dec 9, 2024

Changed to this — I think it looks a bit better?

2024-12-09-20-15-55

@chadwhitacre
Copy link
Contributor

Closes #281.

@chadwhitacre
Copy link
Contributor

Good progress! I would like to bring this to Sentry's design team for refinement.

Also, @selviano and I chatted about this ... wdyt of having both views, with the new card view as the default? Similar to how Google Drive and others offer both list and card view.

image

Card would be the new default, but list would be accessible for digging.

@vladh
Copy link
Member Author

vladh commented Dec 10, 2024

Cool! I can mock that up, and we can see how we like it.

@chadwhitacre
Copy link
Contributor

Filed w/ design 🔒.

@vladh vladh force-pushed the vladh/mockup-new-members-page branch from e176b71 to 0a435bb Compare December 15, 2024 23:49
@vladh
Copy link
Member Author

vladh commented Dec 15, 2024

I implemented a proof of concept for the table/grid toggle, but for now I've left out icons and other visual adjustments, so that I can wait for the proposal from the design team, to avoid toe-stepping.

2024-12-15-23-47-54

@vladh vladh marked this pull request as draft December 16, 2024 17:19
@chadwhitacre
Copy link
Contributor

Sentry's design team isn't going to get to this for a few weeks. I say let's go ahead and land and iterate later.

Is grid the default here, @vladh?

@vladh
Copy link
Member Author

vladh commented Dec 20, 2024

@chadwhitacre Yep, grid is default!

Let me do another design pass on this tomorrow, I could make some things better, and also add icons.

@chadwhitacre
Copy link
Contributor

Can we try out these tweaks?

  • use the same tag/label treatment for "Member" and "Innovator" as we do on the profile pages themselves
  • put the metadata even smaller at the bottom of the card in one line below the prose
  • on hover only change the border and company name, leave the rest unchanged

Wdyt?

@vladh
Copy link
Member Author

vladh commented Dec 20, 2024

Yep, sounds good! Will send some screenshots over early tomorrow. :)

@vladh vladh force-pushed the vladh/mockup-new-members-page branch 3 times, most recently from a766691 to d96cc91 Compare December 21, 2024 15:36
@vladh
Copy link
Member Author

vladh commented Dec 21, 2024

2024-12-21-15-49-18

I think this is nicer:

  • I think the icons turned out okay.
  • I think the member badges do look nice.
  • The numbers are more out of the way at the bottom. This helps reading rhythm, because you go “member name → short description → additional info if you need it”; as opposed to how it was before “member name → so many numbers!”.
  • But, I did remove the join date. I think there's only so much information we can cram in there before it looks too busy. Let's find another place for it. Maybe we can just show it on the member page?

Note: this includes PR #299 for conflict avoidance purposes.

We should be good to merge if you think this looks good enough visually.

@vladh vladh marked this pull request as ready for review December 21, 2024 15:52
@vladh vladh force-pushed the vladh/mockup-new-members-page branch from d96cc91 to e658f36 Compare December 21, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants