Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added promo kit content as mentioned in #196 #247

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

0xvish
Copy link
Contributor

@0xvish 0xvish commented Nov 7, 2024

#196

  • Added promo kit along side existing content on /resources page.
  • Update the links in the existing content.
  • Review and update according to new mockups.

@vladh
Copy link
Member

vladh commented Nov 7, 2024

Thanks @0xvish! Is this ready for review?

@0xvish
Copy link
Contributor Author

0xvish commented Nov 7, 2024

@vladh LGTM, haven't added the href attributes yet, kindly do that as needed.

Otherwise, let me know if any changes are needed after review.

@vladh
Copy link
Member

vladh commented Nov 7, 2024

@0xvish Gotcha! Do you think you could update the links to refer to the corresponding places in our Partner Kit? Let me know if there's confusing in there.

@vladh vladh self-requested a review November 7, 2024 12:47
@vladh
Copy link
Member

vladh commented Nov 7, 2024

Thanks for your help @0xvish! 🙏🏻

I made a few changes:

  • 84125d4 — I noticed there were some unclosed tags, in particular <section> and <main>
  • 9d78355 — I noticed some .highlight-box CSS that would never have an effect
  • 32e25dd — Some headings had the wrong level
  • f988af5 — I made some small tweaks to the spacing and text. Particularly, I removed the pitch deck link, since it seems to be private, I don't have access to it either

I think this is good to merge now — we can make further adjustments as we go along. In particular, I'd like to add our arguments board when it's more fleshed out.

Thanks again! Feel free to log your hours.


@chadwhitacre Do you think we could make the pitch deck link publicly accessible?

@vladh vladh merged commit 9ce5ac7 into opensourcepledge:main Nov 7, 2024
@0xvish 0xvish deleted the vish/resources-page branch November 7, 2024 14:24
@0xvish
Copy link
Contributor Author

0xvish commented Nov 7, 2024

@vladh thanks for the fixes—looks great! 🙌 This was a minor task, so I won’t be claiming hours—happy to contribute in the open-source spirit. I’ll make sure to add my hourly rates to teams.csv for future reference.

@0xvish
Copy link
Contributor Author

0xvish commented Nov 7, 2024

I’d be happy to help with any tasks in the future—feel free to assign me ones you think I can handle!

@chadwhitacre
Copy link
Contributor

Do you think we could make the pitch deck link publicly accessible?

How about downloading it and adding it to this repo?

@chadwhitacre
Copy link
Contributor

Thanks for the contribution @0xvish! :)

@vladh
Copy link
Member

vladh commented Nov 7, 2024

How about downloading it and adding it to this repo?

Can do, but I can't access it myself. Requested access!

@chadwhitacre
Copy link
Contributor

Ah, sorry. Here it is. :)

Open Source Pledge.pdf

@chadwhitacre
Copy link
Contributor

We already have a version of this somewhere in the repo.

@vladh
Copy link
Member

vladh commented Nov 7, 2024

Thanks!

I think we only have the one-pager, but maybe I'm confused: https://github.com/opensourcepledge/opensourcepledge.com/blob/main/public/opensourcepledge.pdf

@chadwhitacre
Copy link
Contributor

chadwhitacre commented Nov 7, 2024

Ah, you're right, I'm confused. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants