[METRICS] Implementation of fixed receiver #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyparrot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1710
這個 PR 實作一個新的 Metric Store receiver
Receiver#fixed(Map<Integer, Collection<BeanObject>)這個 Receiver 只會在第一次呼叫
receive時回傳建立時提供的 Beans，然後就不再回傳任何新的 Beans。後面這個會和 #1769 的序列化功能搭配，從檔案系統將 BeanObjects 還原回Map<Integer, Collection<BeanObject>，然後把這個東西當做輸入給Receiver的輸出使用，而後從MetricStore#clusterBean取得最後的ClusterBean物件。這個大致上是後面 benchmark 的
ClusterBean還原方法。