New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COMMON] separate JndiClient from MBeanClient #1679

Merged

chia7712 merged 1 commit into opensource4you:main from chia7712:separate_jndi_client

Apr 28, 2023

Contributor

chia7712 commented Apr 27, 2023

metrics 在獨立成另一個服務後，理論上我們的 code base 應該要避免直接使用 jndi，這隻PR先將 jndi 的邏輯從 MBeanClient中抽離出來，隨後在適當的時機會將其改成 private (只用於 metrics fetcher)


          [COMMON] separate JndiClient from MBeanClient

845d1b6

Contributor Author

chia7712 commented Apr 27, 2023 •

edited

Loading

@qoo332001 @chinghongfang 麻煩看一下這隻PR，由於現在你們兩個的工作都會遇到 metrics 的重構 ( @qoo332001 你的部分來自於 #1665 (comment))

這隻PR用來幫忙推進一些進度，如果你們沒啥反應的話，隨後我也會將 #1665 (comment) 提到的事情解決

chia7712 merged commit 693c3f3 into opensource4you:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet