Provide exception handler construction for MetricSensors #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Mar 15, 2023
common/src/main/java/org/astraea/common/metrics/collector/MetricSensor.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Mar 16, 2023
common/src/main/java/org/astraea/common/metrics/collector/MetricSensor.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Mar 16, 2023
common/src/main/java/org/astraea/common/metrics/collector/MetricSensor.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1509 (comment)
此 PR 想解決 SmoothWeightRoundRobinPartitioner 撈不到 localBean 的問題，這是因為在撈的過程發生 exception，導致同個節點的其他 cost 也跟著 exception 噴掉
原因
SmoothWeightRoundRobinPartitioner 目前預設使用的 cost function 有四種，分別是
而如果 local 端沒有 BrokerInput、BrokerOutput 的 metrics，mBean client 在撈回來的時候就會噴 exception，導致 CpuCost 與 MemoryCost 也跟著噴掉
目前版本
目前測試使用六台節點，因為都有開啟 Kafka server 所以都能正常拉取上述 metrics，而 Local 因為沒有 Broker 相關 metrics 所以跟著 exception 一起噴了
修改後