Remove unnecessary unpacking #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
dandyrilla
force-pushed
the
remove-unnecessary-unpacking
branch
from
fa2c19a to
e9b1a0f
Compare
Signed-off-by: Sukjun Kim <[email protected]>
dandyrilla
force-pushed
the
remove-unnecessary-unpacking
branch
from
e9b1a0f to
b9682cd
Compare
|
Sorry for force-pushing many commits. I amended commits because I was not familiar with DCO check. Now this PR passes the check. |
|
Looks good, thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am a user who really enjoys and actively utilizes OpenSlide. I would like to express my gratitude to @bgilbert for creating such an excellent open-source project!
What is this PR?
While using the code, I found a small area where I could contribute, so I created a PR with a one-line change. Since the
max()function can accept iterable objects such as generators, it seems that there is no need to unpack them using an asterisk*.Changes
*