Support OpenSlide cache management API #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgilbert
force-pushed
the
cache
branch
2 times, most recently
from
cfdd69f to
24871eb
Compare
bgilbert
force-pushed
the
cache
branch
3 times, most recently
from
314e5bc to
8162c85
Compare
bgilbert
changed the title
|
Ready for review! |
Raise a subclass of OpenSlideError when an unsupported OpenSlide version is detected.
If a minimum OpenSlide version is specified to _func(), and the requested function doesn't exist, succeed at initialization time but raise an exception if the function is called.
They just get stringified and handled as nonexistent files, so we get OpenSlideUnsupportedFormatError.
|
Are there plans to release OpenSlide 3.5.0 soon? These changes match up with the cache management API added to the main project (which also indicates they will be enabled in 3.5.0), and I was just curious if there were any plans for an official release that would allow the changes in this Python library to be used. |
|
The goal is to get to an OpenSlide 3.5.0 release, but that process may take a while yet. API support will almost certainly land in an OpenSlide Python release before OpenSlide 3.5.0 comes out. |
jaharkes
requested changes
May 29, 2022
jaharkes
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the cache management API implemented in openslide/openslide#335. Sample usage: