-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Python 3.7 in tests #236
Conversation
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 26 26
Lines 3602 3602
Branches 261 261
=======================================
Hits 3575 3575
Misses 15 15
Partials 12 12 Continue to review full report at Codecov.
|
Is it really necessary to support a development version of python? The final release is not supposed to be released until June this year. There probably won't be any incompatibilities, there's no need to rush this 😁 . |
@ocaballeror Sure, it is marked as WIP and assigned to milestone 0.7.0. We will not be merging this until 3.7 is out, but wanted to check compatibility before final release. Although unlikely, major releases come with many changes and might break something. Better to spot it early and report it if that is the case. The fact that we are using |
3ddd261
to
d88709e
Compare
7a25fd5
to
554e4b4
Compare
you'll have to use "3.7-dev" for travis because they only have an old 3.7 beta version available right now |
@irmen Thanks! 😊 Yeah, we used that during the 3.7 beta to make sure the new version did not break anything. Not that we are in a hurry, so we will probably wait until By the way, if you want to use 3.7 now I think you can, but you need to use |
@ocaballeror It seems they finally made Xenial available in Travis. It was about time! 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took them long enough 😂
You have my approval 👍
For now this is just to see if everything seems to work fine with 3.7 development branch.It seems everything works fine with Python 3.7.
Update (2018-07-24)
Waiting for Python 3.7 to be available on Travis: travis-ci/travis-ci#9815