Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Python 3.7 in tests #236

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Include Python 3.7 in tests #236

merged 2 commits into from
Nov 14, 2018

Conversation

Peque
Copy link
Member

@Peque Peque commented Feb 5, 2018

For now this is just to see if everything seems to work fine with 3.7 development branch.

It seems everything works fine with Python 3.7.

Update (2018-07-24)

Waiting for Python 3.7 to be available on Travis: travis-ci/travis-ci#9815

@Peque Peque added this to the 0.7.0 milestone Feb 5, 2018
@Peque Peque self-assigned this Feb 5, 2018
@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          26       26           
  Lines        3602     3602           
  Branches      261      261           
=======================================
  Hits         3575     3575           
  Misses         15       15           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1c4b0...0344cb3. Read the comment docs.

@ocaballeror
Copy link
Contributor

Is it really necessary to support a development version of python? The final release is not supposed to be released until June this year.

There probably won't be any incompatibilities, there's no need to rush this 😁 .

@Peque
Copy link
Member Author

Peque commented Feb 5, 2018

@ocaballeror Sure, it is marked as WIP and assigned to milestone 0.7.0. We will not be merging this until 3.7 is out, but wanted to check compatibility before final release.

Although unlikely, major releases come with many changes and might break something. Better to spot it early and report it if that is the case. The fact that we are using 3.4.4 in Travis is actually an example of 3.4.3 being broken (in this case a broken minor release). Checking all minor releases before they are out is not worth it, but major releases are worth it in my opinion (fortunately they do not occur very often).

@Peque Peque force-pushed the python37 branch 5 times, most recently from 3ddd261 to d88709e Compare March 5, 2018 13:40
@Peque Peque force-pushed the python37 branch 2 times, most recently from 7a25fd5 to 554e4b4 Compare July 24, 2018 16:21
@Peque Peque removed the wip label Jul 24, 2018
@Peque Peque changed the title [WIP] Include Python 3.7 in tests Include Python 3.7 in tests Jul 24, 2018
.travis.yml Show resolved Hide resolved
@irmen
Copy link

irmen commented Aug 5, 2018

you'll have to use "3.7-dev" for travis because they only have an old 3.7 beta version available right now

@Peque
Copy link
Member Author

Peque commented Aug 5, 2018

@irmen Thanks! 😊

Yeah, we used that during the 3.7 beta to make sure the new version did not break anything. Not that we are in a hurry, so we will probably wait until 3.7 is available in Travis (hope it wont take too long!). 😂

By the way, if you want to use 3.7 now I think you can, but you need to use sudo: true and dist: xenial in your travis.yml file. A bit of a hack... 😅

@Peque
Copy link
Member Author

Peque commented Nov 14, 2018

@ocaballeror It seems they finally made Xenial available in Travis. It was about time! 😂

Copy link
Contributor

@ocaballeror ocaballeror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took them long enough 😂

You have my approval 👍

@Peque Peque merged commit 0344cb3 into opensistemas-hub:master Nov 14, 2018
@Peque Peque deleted the python37 branch March 11, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants