Update README with ssh key information #24
Conversation
openshift-ci-robot
added
the
approved
|
/approve cancel /hold |
openshift-ci-robot
added
do-not-merge/hold
|
/lgtm |
README.md
Outdated
| @@ -19,8 +19,11 @@ To run the e2e tests for WMCO locally against an OpenShift cluster set up on AWS | |||
| export KUBECONFIG=<path to kubeconfig> | |||
| export AWS_SHARED_CREDENTIALS_FILE=<path to aws credentials file> | |||
| export CLUSTER_ADDR=<cluster_name, eg: ravig211.devcluster.openshift.com> | |||
| export KUBE_SSH_KEY_PATH=<path to ssh key> | |||
| export KUBE_SSH_KEY_PATH=<path to ssh key> | |||
There was a problem hiding this comment.
extra space. Will remove it.
There was a problem hiding this comment.
Thanks for working on this, @ravisantoshgudimetla. Please address my comments.
README.md
Outdated
| Make sure that the key you're using in KUBE_SSH_KEY_PATH is | ||
| private key part of the keypair mentioned at [sshKeyPair](https://github.com/openshift/windows-machine-config-operator/blob/42593c5d2eb798b572c58b5debafc4c392d1f967/test/e2e/wmco_test.go#L59) within the instance CR |
There was a problem hiding this comment.
This implies that you need to change KUBE_SSH_KEY_PATH to point to libra which we cannot do in development. This should rather say, Update the keypair mentioned at sshKeyPair to match what is being used in KUBE_SSH_KEY_PATH. Also call out that libra is being used for CI purposes.
BTW, did you try hard coding to openshift-dev? I think the test platform team has uploaded that key to all AWS regions in the CI account when they decided to do region sharding for CI. Please try this out in a separate PR and move to using that if it works.
There was a problem hiding this comment.
BTW, did you try hard coding to openshift-dev? I think the test platform team has uploaded that key to all AWS regions in the CI account when they decided to do region sharding for CI. Please try this out in a separate PR and move to using that if it works.
I tried it multiple times in the CI for #15 and it failed.
This implies that you need to change KUBE_SSH_KEY_PATH to point to libra which we cannot do in development. This should rather say, Update the keypair mentioned at sshKeyPair to match what is being used in KUBE_SSH_KEY_PATH. Also call out that libra is being used for CI purposes.
Will do that.
ravisantoshgudimetla
force-pushed
the
fix-dev-flow
branch
from
b97f5a8 to
ce229f6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ravisantoshgudimetla
force-pushed
the
fix-dev-flow
branch
from
ce229f6 to
2e8fdc8
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold Until #23 merges |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel as #23 merged |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ravisantoshgudimetla: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[wni] Azure Implementation
As of now, go.sum on master branch is broken. The PR openshift#24 broke it. This commit should fix the broken go.sum. We need to run `go mod verify` in the wni directory to generate the go.sum file again, building from wmco location using make build-tools won't generate the go.sum
cc @aravindhp @akhil-rane @openshift/openshift-team-windows-containers