Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI #316

Conversation

mateusoliveira43
Copy link

Fix CI updating controller gen version used to match velero's.

Signed-off-by: Mateus Oliveira <[email protected]>
Copy link

openshift-ci bot commented Jun 12, 2024

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mateusoliveira43
Copy link
Author

/cherry-pick oadp-1.4

@openshift-cherrypick-robot

@mateusoliveira43: once the present PR merges, I will cherry-pick it on top of oadp-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@mateusoliveira43 mateusoliveira43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@mateusoliveira43
Copy link
Author

manually added approved label, as OWNERS file have wrong syntax for our PROW (github usernames with @)

Copy link

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mateusoliveira43, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9bff8b4 into openshift:konveyor-dev Jun 17, 2024
3 checks passed
@openshift-cherrypick-robot

@mateusoliveira43: new pull request created: #319

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mateusoliveira43
Copy link
Author

/cherry-pick oadp-1.4

@openshift-cherrypick-robot

@mateusoliveira43: new pull request could not be created: failed to create pull request against openshift/velero#oadp-1.4 from head openshift-cherrypick-robot:cherry-pick-316-to-oadp-1.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-316-to-oadp-1.4."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai kaovilai mentioned this pull request Jun 18, 2024
3 tasks
shubham-pampattiwar pushed a commit that referenced this pull request Aug 22, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Sep 19, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Dec 11, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants