Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_gcp build tag to make it run on GCP 🏃 #300

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

vdemeester
Copy link
Member

Now that master has the upstream "fix"
tektoncd@530f084,
we can use this build tag to disable the GCP credentialprovider and
make OpenShift Pipeline work on GCP.

Signed-off-by: Vincent Demeester [email protected]

Now that master has the upstream "fix"
tektoncd@530f084,
we can use this build tag to disable the GCP credentialprovider and
make OpenShift Pipeline work on GCP.

Signed-off-by: Vincent Demeester <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@chmouel
Copy link
Member

chmouel commented Jan 20, 2020

So you set the tag disable_gcp to make it works on gcp ? 🤔

@vdemeester
Copy link
Member Author

So you set the tag disable_gcp to make it works on gcp ? thinking

Yes 😛 It disables the credentialprovider of gcp (see here) by removing the import to it… which make the "infinite loop" describe in this issue go away (as it doesn't execute that code anymore).

@chmouel
Copy link
Member

chmouel commented Jan 20, 2020

yeah but a tag name credentialprovier-disable-gcp would have been very welcome :-p

time to redo the whole dependencies PR dance 😛

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3717f5a into openshift:master Jan 20, 2020
@vdemeester vdemeester deleted the disable-gcp branch January 20, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants