Use upstream nop image to fix sidecar tests. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to rewrite all of this one day, it is pretty weird. Signed-off-by: Chmouel Boudjnah <[email protected]>
This is a very cheeky hack, sidecar is currently broken with our nop image so we just use nightly `nop` from upstream CI. `nop` should not change or do anything differently with a different base so we should be safe until tektoncd#1347 gets fixed. Signed-off-by: Chmouel Boudjnah <[email protected]>
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
vdemeester
approved these changes
Sep 24, 2019
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
|
/unhold |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, sthaha, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to get the TestSidecar working.
Full on discussion here (RH Only): https://coreos.slack.com/archives/CG5GV6CJD/p1568983413242300
We need to get tektoncd#1347 fixed to remove this hack.
TODO: rewrite e2e test and resolve_resource shell script in something else (python?), it becomes way too much spagethini-shelly and too much error prone 🍝