-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use upstream nop image to fix sidecar tests. #136
Use upstream nop image to fix sidecar tests. #136
Conversation
We need to rewrite all of this one day, it is pretty weird. Signed-off-by: Chmouel Boudjnah <[email protected]>
This is a very cheeky hack, sidecar is currently broken with our nop image so we just use nightly `nop` from upstream CI. `nop` should not change or do anything differently with a different base so we should be safe until tektoncd#1347 gets fixed. Signed-off-by: Chmouel Boudjnah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
/cc @sthaha @nikhil-thomas
/lgtm |
/unhold |
/hold cancel |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, sthaha, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hack to get the TestSidecar working.
Full on discussion here (RH Only): https://coreos.slack.com/archives/CG5GV6CJD/p1568983413242300
We need to get tektoncd#1347 fixed to remove this hack.
TODO
: rewrite e2e test and resolve_resource shell script in something else (python?), it becomes way too much spagethini-shelly and too much error prone 🍝