Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients #1054

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients #1054

merged 1 commit into from
Oct 6, 2020

Conversation

gabemontero
Copy link
Contributor

/assign @adambkaplan

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Oct 5, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1884270, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 5, 2020
gabemontero
gabemontero commented Oct 5, 2020
View reviewed changes
pkg/scm/git/url.go Outdated Show resolved Hide resolved
@gabemontero gabemontero changed the title WIP: Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients Oct 6, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2020
@gabemontero
Copy link
Contributor Author

OK @adambkaplan per slack discussion let's go with this .... PTAL

adambkaplan
adambkaplan approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8fdb399 into openshift:master Oct 6, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 1884270 has been moved to the MODIFIED state.

In response to this:

Bug 1884270: bypass golang url parsing with scp styled ssh git URLs; refactor URL for older git clients

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the scp-styled-ssh-git-uri branch October 7, 2020 18:45
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 9, 2020
Merged
@gabemontero gabemontero mentioned this pull request Jul 6, 2021
Closed
@gabemontero gabemontero mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@bparees bparees Awaiting requested review from bparees

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabemontero @openshift-ci-robot @adambkaplan @openshift-merge-robot