Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42375: OpenStack: export new SR-IOV related images #56991

Merged

Conversation

mandre
Copy link
Member

@mandre mandre commented Sep 20, 2024

Export new images needed in 4.18.

Here is an example of a failed job.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@mandre
Copy link
Member Author

mandre commented Sep 20, 2024

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel

@openshift-ci-robot
Copy link
Contributor

@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@MaysaMacedo
Copy link
Contributor

/lgtm

let's wait for CI result before merging

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@mandre
Copy link
Member Author

mandre commented Sep 20, 2024

It's not enough. The hack/env.sh file is broken in the source repo. I have a fix here but for some reason github doesn't allow me to submit a PR to https://github.com/k8snetworkplumbingwg/sriov-network-operator 😕

@mandre mandre changed the title OpenStack: export empty RDMA_CNI_IMAGE OCPBUGS-42375: OpenStack: export empty RDMA_CNI_IMAGE Sep 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 24, 2024
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-42375, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is now needed when installing the operator from source.

Here is an example of a failed job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MiguelCarpio
Copy link
Contributor

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel

@openshift-ci-robot
Copy link
Contributor

@MiguelCarpio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mandre
Copy link
Member Author

mandre commented Sep 26, 2024

This needs downstream sriov-network-operator to include k8snetworkplumbingwg/sriov-network-operator#780 first.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@mandre mandre force-pushed the openstack-sriov-rdma-cni branch from 1be7987 to 204d442 Compare October 2, 2024 12:22
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@mandre
Copy link
Member Author

mandre commented Oct 2, 2024

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel

@openshift-ci-robot
Copy link
Contributor

@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mandre
Copy link
Member Author

mandre commented Oct 3, 2024

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel

@openshift-ci-robot
Copy link
Contributor

@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Export new images needed in 4.18
@mandre mandre force-pushed the openstack-sriov-rdma-cni branch from 3e3c1a2 to 552e822 Compare October 3, 2024 09:30
@mandre
Copy link
Member Author

mandre commented Oct 3, 2024

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel

@openshift-ci-robot
Copy link
Contributor

@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mandre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-api-provider-openstack-release-4.13-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.12-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-mellanox openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-master-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.19-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.18-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.17-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.16-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.15-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.14-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.10-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed

A total of 46 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mandre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-release-4.10-e2e-openstack-nfv-mellanox openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.9-e2e-openstack-nfv-mellanox openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.10-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-openstack-capi-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.15-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-openstack-nfv-intel openshift/installer presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.13-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.12-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-mellanox openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-master-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.19-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.18-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed

A total of 46 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre mandre changed the title OCPBUGS-42375: OpenStack: export empty RDMA_CNI_IMAGE OCPBUGS-42375: OpenStack: export new SR-IOV related images Oct 3, 2024
@mandre
Copy link
Member Author

mandre commented Oct 3, 2024

/pj-rehearse ack

@mandre
Copy link
Member Author

mandre commented Oct 3, 2024

/hold cancel

@EmilienM
Copy link
Member

EmilienM commented Oct 3, 2024

/lgtm
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 3, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2024
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MiguelCarpio
Copy link
Contributor

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@MiguelCarpio
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 3, 2024
@openshift-ci-robot
Copy link
Contributor

@MiguelCarpio: This pull request references Jira Issue OCPBUGS-42375, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2024
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 09b8b49 into openshift:master Oct 3, 2024
11 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the openstack-sriov-rdma-cni branch October 3, 2024 13:19
@openshift-ci-robot
Copy link
Contributor

@mandre: Jira Issue OCPBUGS-42375: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42375 has been moved to the MODIFIED state.

In response to this:

Export new images needed in 4.18.

Here is an example of a failed job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants